Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 126713004: Remove Node.prefix so it's no longer visible to script. (Closed)

Created:
6 years, 11 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 11 months ago
Reviewers:
ojan
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove Node.prefix so it's no longer visible to script. This is in line with DOM4 <http://dom.spec.whatwg.org/#node>; prefix remains on Attr and Element, which is the only place it does something useful, although setting prefixes will probably be removed entirely. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164729

Patch Set 1 #

Patch Set 2 : Remove spurious OVERRIDE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -31 lines) Patch
M LayoutTests/fast/dom/Node/initial-values-expected.txt View 4 chunks +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/dom/Node/script-tests/initial-values.js View 8 chunks +0 lines, -8 lines 0 comments Download
M Source/core/dom/Attr.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dominicc (has gone to gerrit)
6 years, 11 months ago (2014-01-08 01:04:07 UTC) #1
ojan
lgtm
6 years, 11 months ago (2014-01-08 18:52:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/126713004/1
6 years, 11 months ago (2014-01-08 18:53:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=16617
6 years, 11 months ago (2014-01-08 19:48:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/126713004/210001
6 years, 11 months ago (2014-01-09 00:12:22 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 02:41:03 UTC) #6
Message was sent while issue was closed.
Change committed as 164729

Powered by Google App Engine
This is Rietveld 408576698