Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tools/telemetry/catapult_base/support_binaries.py

Issue 1267123004: Temporarily fix downloads via support binaries on windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/catapult_base/support_binaries.py
diff --git a/tools/telemetry/catapult_base/support_binaries.py b/tools/telemetry/catapult_base/support_binaries.py
index 8f73f99411418135eca6bf0f03f57c6c0de23f0b..9caaf6ff300563f706289160782f52dd487fc2bf 100644
--- a/tools/telemetry/catapult_base/support_binaries.py
+++ b/tools/telemetry/catapult_base/support_binaries.py
@@ -56,6 +56,11 @@ def FindPath(binary_name, arch_name, platform_name):
if command and os.path.exists(command):
os.chmod(command,
stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR | stat.S_IRGRP)
+ if not command and platform_name == 'win' and arch_name != 'AMD64':
+ # This is an awful, awful hack to temporarily fix cloud_storage downloads
+ # on XP until the binary_manager is finished and migrated to.
+ # Please don't try this at home.
+ return FindPath(binary_name, 'AMD64', platform_name)
# Return an absolute path consistently.
if command:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698