Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: android_webview/native/aw_contents.cc

Issue 1267103003: Deny the geolocation permission request by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index d92640407a20a6f15e71cc9ae7029ef0c4c8b494..58782a83c208964e36fded331efb7e40a849e4ac 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -491,11 +491,8 @@ void AwContents::InvokeGeolocationCallback(JNIEnv* env,
jboolean value,
jstring origin) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (pending_geolocation_prompts_.empty()) {
- LOG(WARNING) << "Response for this geolocation request has been received."
- << " Ignoring subsequent responses";
+ if (pending_geolocation_prompts_.empty())
return;
- }
GURL callback_origin(base::android::ConvertJavaStringToUTF16(env, origin));
if (callback_origin.GetOrigin() ==
@@ -506,9 +503,6 @@ void AwContents::InvokeGeolocationCallback(JNIEnv* env,
ShowGeolocationPromptHelper(java_ref_,
pending_geolocation_prompts_.front().first);
}
- } else {
- LOG(WARNING) << "Response for this geolocation request has been received."
- << " Ignoring subsequent responses";
}
}
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698