PerformanceTests/SVG/Bamboo_transform.html - Issue 1267093002: add SVG zoom/scroll case to perf test

Side by Side Diff: PerformanceTests/SVG/Bamboo_transform.html

Issue 1267093002: add SVG zoom/scroll case to perf test (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add raf workload Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <pre id="log"></pre>
	fs 2015/08/19 23:04:32 Add <!DOCTYPE html>? (Who wants quirks mode anyway Add <!DOCTYPE html>? (Who wants quirks mode anyway?) junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 23:04:32, fs wrote: > Add <!DOCTYPE html>? (Who wants quirks mode anyway?) Done.
	2 <div id="svg-div">

	3 <embed id="svg-content" src="./resources/Bamboo.svg" width="400px" height="4 00px" type="image/svg+xml" />
	fs 2015/08/19 23:04:31 Use <object> instead of <embed>? Use <object> instead of <embed>? junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 23:04:31, fs wrote: > Use <object> instead of <embed>? Done.
	4 </div>

	5 <script src="../resources/runner.js"></script>

	6 <script>

	7 var svgContent;

	8 var startTime;

	9 var endTime;

	10 var loop0 = 20;
	pdr. 2015/08/19 17:28:35 Lets change this to a static in all caps. Maybe va Lets change this to a static in all caps. Maybe var LOOP_ITERATIONS = 20;? junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 17:28:35, pdr wrote: > Lets change this to a static in all caps. Maybe var LOOP_ITERATIONS = 20;? Done.
	11 var loop = loop0;

	12 var offset = 0;

	13 var state = 'zoomin';

	14 var delta = 1;

	15 var step = function(){

	16 loop--;

	17 if (loop==0){

	18 loop = loop0;

	19 if (state=='zoomin'){

	20 state='scroll';

	21 delta = 0;

	22 }

	23 else if (state=='scroll'){

	24 state='zoomout';

	25 delta = 2;

	26 }

	27 else if (state=='zoomout'){

	28 endTime = Date.now();
	pdr. 2015/08/19 17:28:35 Lets use performance.now if available: endTime = w Lets use performance.now if available: endTime = window.performance ? performance.now() : Date.now(); junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 17:28:35, pdr wrote: > Lets use performance.now if available: > endTime = window.performance ? performance.now() : Date.now(); Done.
	29 var log = document.getElementById("log");

	30 log.innerHTML += "values "+(endTime-startTime)+" ms";

	31 testRunner.notifyDone();

	32 return;

	33 }

	34 }

	35 if (state=='zoomin'){
	pdr. 2015/08/19 17:28:35 Lets replace these if(...) blocks with a switch st Lets replace these if(...) blocks with a switch statement (here, and above) junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 17:28:35, pdr wrote: > Lets replace these if(...) blocks with a switch statement (here, and above) Done.
	36 delta += 0.05;

	37 svgContent.style.transform='matrix('+delta+',0,0,'+delta+',0,0)';

	38 }

	39 if (state=='scroll'){

	40 if (loop>loop0/2) delta += 20;

	41 else delta -= 20;

	42 svgContent.style.transform='matrix(2,0,0,2,'+delta+',0)';

	43 }

	44 if (state=='zoomout'){

	45 delta -= 0.05;

	46 svgContent.style.transform='matrix('+delta+',0,0,'+delta+',0,0)';

	47 }

	48 requestAnimationFrame(step);

	49 };

	50 var init = function(){

	51 try{

	52 svgContent = document.getElementById('svg-content').getSVGDocument().doc umentElement;
	fs 2015/08/19 23:04:31 Prefer to not use getSVGDocument() - contentDocume Prefer to not use getSVGDocument() - contentDocument ought to work as well. junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 23:04:31, fs wrote: > Prefer to not use getSVGDocument() - contentDocument ought to work as well. Done.
	53 startTime = Date.now();

	54 requestAnimationFrame(step);

	55 }

	56 catch(err){

	57 setTimeout(init,100);
	fs 2015/08/19 23:04:32 This looks a bit sketchy - listen for a load event This looks a bit sketchy - listen for a load event instead? junchao.han 2015/08/20 06:32:47 Done. Show quoted text On 2015/08/19 23:04:32, fs wrote: > This looks a bit sketchy - listen for a load event instead? Done.
	58 }

	59 };

	60 init();

	61 </script>

OLD	NEW

« no previous file with comments | « no previous file | PerformanceTests/SVG/resources/Bamboo.svg » ('j') | PerformanceTests/SVG/resources/Bamboo.svg » ('J')