Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1267073004: Revert of [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43. (Closed)

Created:
5 years, 4 months ago by miu
Modified:
5 years, 4 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43. (patchset #1 id:1 of https://codereview.chromium.org/1009643002/) Reason for revert: As discussed in bug 466357, the plan was to revert this patchset for Chrome 44 and later. These fields will be gone starting in Chrome 46, assuming this lands within the next couple weeks. Original issue's description: > [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43. > > A recent change (https://codereview.chromium.org/973753002/) removed the > width/height properties from the IDL, but the Google Cast Extension needs > them to be present until a patch rolls out to all Chrome Canary/Dev/Beta > users. > > BUG=466357 > TBR=finnur@chromium.org > > Committed: https://crrev.com/5ba8aa856919269a1a079c376d70480da0c2fc23 > Cr-Commit-Position: refs/heads/master@{#320634} TBR=finnur@chromium.org BUG=466357 Committed: https://crrev.com/6c3cda906f10db581a6df15d0f0324fd6aa2dbd5 Cr-Commit-Position: refs/heads/master@{#341474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
miu
Created Revert of [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43.
5 years, 4 months ago (2015-08-02 00:58:26 UTC) #1
miu
FYI...About to do a CQ dry-run, and I will land if that passes.
5 years, 4 months ago (2015-08-02 00:59:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267073004/1
5 years, 4 months ago (2015-08-02 00:59:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-02 02:16:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1267073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1267073004/1
5 years, 4 months ago (2015-08-02 02:34:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-02 02:39:59 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-02 02:40:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c3cda906f10db581a6df15d0f0324fd6aa2dbd5
Cr-Commit-Position: refs/heads/master@{#341474}

Powered by Google App Engine
This is Rietveld 408576698