Revert to zero-initializing buffers for FFmpegVideoDecoder

media/base/video_frame.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/video_frame.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 607 matching lines @@
 
 bool VideoFrame::HasTextures() const {
   return !mailbox_holders_[0].mailbox.IsZero();
 }
 
 int VideoFrame::stride(size_t plane) const {
   DCHECK(IsValidPlane(plane, format_));
   return strides_[plane];
 }
 
+size_t VideoFrame::allocated_size() const {
+  DCHECK(IsYuvPlanar(format_));
+  DCHECK_EQ(storage_type_, STORAGE_OWNED_MEMORY);
+
+  // If CreateFrame() method is used, return the size with alignments and
+  // padding.
+  if (allocated_size_)

[DaleCurtis, 2015/08/04 19:07:44]

Just default to zero in all cases except the AllocateYUV case, then this can be
a simple accessor.

[emircan, 2015/08/04 19:54:35]

Done.

+    return allocated_size_;
+
+  return VideoFrame::AllocationSize(format_, coded_size_);
+}
+
 int VideoFrame::row_bytes(size_t plane) const {
   return RowBytes(plane, format_, coded_size_.width());
 }
 
 int VideoFrame::rows(size_t plane) const {
   return Rows(plane, format_, coded_size_.height());
 }
 
 const uint8* VideoFrame::data(size_t plane) const {
   DCHECK(IsValidPlane(plane, format_));
@@ skipping 250 matching lines @@
 
   // The extra line of UV being allocated is because h264 chroma MC
   // overreads by one line in some cases, see libavcodec/utils.c:
   // avcodec_align_dimensions2() and libavcodec/x86/h264_chromamc.asm:
   // put_h264_chroma_mc4_ssse3().
   DCHECK(IsValidPlane(kUPlane, format_));
   data_size += strides_[kUPlane] + kFrameSizePadding;
 
   uint8* data = reinterpret_cast<uint8*>(
       base::AlignedAlloc(data_size, kFrameAddressAlignment));
-
   for (size_t plane = 0; plane < NumPlanes(format_); ++plane)
     data_[plane] = data + offset[plane];
 
   AddDestructionObserver(base::Bind(&base::AlignedFree, data));
+
+  // Make sure that allocated_size() returns the same size as allocated here.
+  allocated_size_ = data_size;
 }
 
 }  // namespace media