Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6505)

Unified Diff: chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 12670013: Out-of-process import on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: extract some more CLs Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/ie_importer_browsertest_win.cc
diff --git a/chrome/browser/importer/ie_importer_browsertest_win.cc b/chrome/browser/importer/ie_importer_browsertest_win.cc
index d7f9bf338a943bf33642091764d00c2900127bd6..7ed848ca9cd72e08f77d66ec2b634cf6302fd2e0 100644
--- a/chrome/browser/importer/ie_importer_browsertest_win.cc
+++ b/chrome/browser/importer/ie_importer_browsertest_win.cc
@@ -29,6 +29,7 @@
#include "base/win/scoped_propvariant.h"
#include "base/win/windows_version.h"
#include "chrome/browser/history/history_types.h"
+#include "chrome/browser/importer/external_process_importer_host.h"
#include "chrome/browser/importer/ie_importer.h"
#include "chrome/browser/importer/importer_bridge.h"
#include "chrome/browser/importer/importer_data_types.h"
@@ -510,8 +511,7 @@ IN_PROC_BROWSER_TEST_F(IEImporterBrowserTest, IEImporter) {
ASSERT_TRUE(res == S_OK);
// Starts to import the above settings.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- scoped_refptr<ImporterHost> host(new ImporterHost);
+ scoped_refptr<ImporterHost> host(new ExternalProcessImporterHost);
TestObserver* observer = new TestObserver();
host->SetObserver(observer);
@@ -588,8 +588,7 @@ IN_PROC_BROWSER_TEST_F(IEImporterBrowserTest,
REG_BINARY));
// Starts to import the above settings.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- scoped_refptr<ImporterHost> host(new ImporterHost);
+ scoped_refptr<ImporterHost> host(new ExternalProcessImporterHost);
MalformedFavoritesRegistryTestObserver* observer =
new MalformedFavoritesRegistryTestObserver();
host->SetObserver(observer);

Powered by Google App Engine
This is Rietveld 408576698