Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9836)

Unified Diff: chrome/browser/importer/ie_importer_browsertest_win.cc

Issue 12670013: Out-of-process import on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on top of https://codereview.chromium.org/15736014/ Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/ie_importer_browsertest_win.cc
diff --git a/chrome/browser/importer/ie_importer_browsertest_win.cc b/chrome/browser/importer/ie_importer_browsertest_win.cc
index 3442be59900104b8d684c16e50f96e763268be13..b8d6091f9e033a45d152dcd8bdb6685724b70586 100644
--- a/chrome/browser/importer/ie_importer_browsertest_win.cc
+++ b/chrome/browser/importer/ie_importer_browsertest_win.cc
@@ -30,6 +30,7 @@
#include "base/win/windows_version.h"
#include "chrome/browser/bookmarks/imported_bookmark_entry.h"
#include "chrome/browser/favicon/imported_favicon_usage.h"
+#include "chrome/browser/importer/external_process_importer_host.h"
#include "chrome/browser/importer/ie_importer.h"
#include "chrome/browser/importer/ie_importer_utils_win.h"
#include "chrome/browser/importer/ie_importer_test_registry_overrider_win.h"
@@ -486,8 +487,7 @@ IN_PROC_BROWSER_TEST_F(IEImporterBrowserTest, IEImporter) {
// Starts to import the above settings.
// Deletes itself.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- ImporterHost* host = new ImporterHost;
+ ImporterHost* host = new ExternalProcessImporterHost;
TestObserver* observer = new TestObserver();
host->SetObserver(observer);
@@ -563,8 +563,7 @@ IN_PROC_BROWSER_TEST_F(IEImporterBrowserTest,
// Starts to import the above settings.
// Deletes itself.
- // TODO(gab): Use ExternalProcessImporterHost on Windows.
- ImporterHost* host = new ImporterHost;
+ ImporterHost* host = new ExternalProcessImporterHost;
MalformedFavoritesRegistryTestObserver* observer =
new MalformedFavoritesRegistryTestObserver();
host->SetObserver(observer);
« no previous file with comments | « chrome/browser/importer/firefox_importer_browsertest.cc ('k') | chrome/browser/policy/cloud/user_policy_signin_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698