Out-of-process import on Windows.

chrome/browser/ui/webui/options/import_data_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/import_data_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 91 matching lines @@
       importer_list_->GetSourceProfileAt(browser_index);
   uint16 supported_items = source_profile.services_supported;
 
   uint16 import_services = (selected_items & supported_items);
   if (import_services) {
     base::FundamentalValue state(true);
     web_ui()->CallJavascriptFunction("ImportDataOverlay.setImportingState",
                                      state);
     import_did_succeed_ = false;
 
-    // TODO(csilv): Out-of-process import has only been qualified on MacOS X,
-    // so we will only use it on that platform since it is required. Remove this
-    // conditional logic once oop import is qualified for Linux/Windows.
-    // http://crbug.com/22142
-#if defined(OS_MACOSX)
-    importer_host_ = new ExternalProcessImporterHost;
+    // TODO(gab): Make Linux use OOP import as well (http://crbug.com/56816) and
+    // get rid of these ugly ifdefs.
+#if defined(OS_MACOSX) || defined(OS_WIN)
+    // The Google Toolbar import doesn't work for the out-of-process import.

[Nico, 2013/04/29 03:24:54]

Maybe call out that Google Toolbar import never runs at startup / first run.

The sync folks probably have thought about importing google bookmarks, so maybe
doing this toolbar import server-side might make sense long term. Ask them what
they think.

[gab, 2013/04/29 12:41:53]

Done.
Yes, I already talked about this with them F2F and on http://crbug.com/219419.
It would probably make sense for this to happen automatically when signing in to
Chrome for the first time. Keeping the toolbar importer as part of the import
code will soon become a big platform-specific/not well tested/unQAed(AFAIK) code
burden as this will become the only code that needs the in-process import flow.
(Also, it's Windows only because it's Toolbar I guess, but technically the
bookmarks are in the cloud and could be synced to any OS...).

Currently gathering stats about which importer gets used from each entry point,
we'll soon make a move based on that (http://crbug.com/234354).

+    // See discussion on http://crbug.com/219419 for details.
+    if (source_profile.importer_type == importer::TYPE_GOOGLE_TOOLBAR5)
+      importer_host_ = new ImporterHost;
+    else
+      importer_host_ = new ExternalProcessImporterHost;
 #else
     importer_host_ = new ImporterHost;
 #endif
     importer_host_->SetObserver(this);
     importer_host_->set_browser(
         chrome::FindBrowserWithWebContents(web_ui()->GetWebContents()));
     Profile* profile = Profile::FromWebUI(web_ui());
     importer_host_->StartImportSettings(source_profile, profile,
                                         import_services,
                                         new ProfileWriter(profile));
@@ skipping 59 matching lines @@
     web_ui()->CallJavascriptFunction("ImportDataOverlay.confirmSuccess");
   } else {
     base::FundamentalValue state(false);
     web_ui()->CallJavascriptFunction("ImportDataOverlay.setImportingState",
                                      state);
     web_ui()->CallJavascriptFunction("ImportDataOverlay.dismiss");
   }
 }
 
 }  // namespace options