Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1266983002: VectorICs: Crankshaft adaptations to deal with vector store ics. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Crankshaft adaptations to deal with vector store ics. Also, a one line fix in TurboFan to call the correct store ic. BUG= Committed: https://crrev.com/f8a4afa7bdc6304946e5ed63a196db6e84fd7755 Cr-Commit-Position: refs/heads/master@{#29952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -134 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 5 chunks +25 lines, -38 lines 0 comments Download
M src/hydrogen.cc View 37 chunks +120 lines, -95 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Benedikt, thanks for the look! --Michael
5 years, 4 months ago (2015-07-31 11:31:00 UTC) #2
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-07-31 11:34:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266983002/1
5 years, 4 months ago (2015-07-31 11:36:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 11:56:08 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 11:56:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a4afa7bdc6304946e5ed63a196db6e84fd7755
Cr-Commit-Position: refs/heads/master@{#29952}

Powered by Google App Engine
This is Rietveld 408576698