Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1266943005: Fix http requests and the crash dump RPC (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/crash_dump_test.dart ('k') | runtime/vm/service/message.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 15076a153117c4c4cfa0e3fd6fb56bf3af74f9ed..4c492edefe43d0e274ae04b45b210de7eb01a9b1 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -86,6 +86,10 @@ class _TestLauncher {
typedef Future IsolateTest(Isolate isolate);
typedef Future VMTest(VM vm);
+/// Will be set to the http address of the VM's service protocol before
+/// any tests are invoked.
+String serviceHttpAddress;
+
/// Runs [tests] in sequence, each of which should take an [Isolate] and
/// return a [Future]. Code for setting up state can run before and/or
/// concurrently with the tests. Uses [mainArgs] to determine whether
@@ -112,6 +116,7 @@ void runIsolateTests(List<String> mainArgs,
port = 8181;
}
String addr = 'ws://localhost:$port/ws';
+ serviceHttpAddress = 'http://localhost:$port';
var testIndex = 1;
var totalTests = tests.length;
var name = Platform.script.pathSegments.last;
@@ -299,6 +304,7 @@ Future runVMTests(List<String> mainArgs,
port = 8181;
}
String addr = 'ws://localhost:$port/ws';
+ serviceHttpAddress = 'http://localhost:$port';
var testIndex = 1;
var totalTests = tests.length;
var name = Platform.script.pathSegments.last;
« no previous file with comments | « runtime/observatory/tests/service/crash_dump_test.dart ('k') | runtime/vm/service/message.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698