runtime/observatory/lib/src/elements/logging.dart - Issue 1266943005: Fix http requests and the crash dump RPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/logging.dart

Issue 1266943005: Fix http requests and the crash dump RPC (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/logging.dart

diff --git a/runtime/observatory/lib/src/elements/logging.dart b/runtime/observatory/lib/src/elements/logging.dart

index 6e22aadb387e6dfeb6a25938b40d525e987a7b01..8f263050e1657d803f9ba75e41e129b4c26b3959 100644

--- a/runtime/observatory/lib/src/elements/logging.dart

+++ b/runtime/observatory/lib/src/elements/logging.dart

@@ -156,9 +156,8 @@ class LoggingPageElement extends ObservatoryElement {

_flushPendingLogs() {

DivElement logContainer = shadowRoot.querySelector(_kLogSelector);

bool autoScroll = _isScrolledToBottom(logContainer);

- var lastElement;

for (var logRecord in pendingLogRecords) {

- lastElement = _renderAppend(logRecord);

+ _renderAppend(logRecord);

}

if (autoScroll) {

_scrollToBottom(logContainer);