Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_local_test.dart

Issue 1266923004: More fixes for failures on the Windows bot (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_local_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_local_test.dart b/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
index 81bc8b86ef2d81584b8e74346721f808d962d08e..dda32edb3e501507ba84bb0cae858bfdb3991fcc 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_local_test.dart
@@ -9,10 +9,11 @@ import 'package:analysis_server/src/services/correction/status.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
import 'package:unittest/unittest.dart';
+import '../../utils.dart';
import 'abstract_rename.dart';
main() {
- groupSep = ' | ';
+ initializeTestEnvironment();
defineReflectiveTests(RenameLocalTest);
}
@@ -131,7 +132,7 @@ class A {
RefactoringStatus status = await refactoring.checkFinalConditions();
assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
expectedMessage: 'Usage of field "A.newName" declared in "test.dart" '
- 'will be shadowed by renamed local variable.',
+ 'will be shadowed by renamed local variable.',
expectedContextSearch: 'newName);');
}
@@ -154,7 +155,7 @@ class B extends A {
RefactoringStatus status = await refactoring.checkFinalConditions();
assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
expectedMessage: 'Usage of field "B.newName" declared in "test.dart" '
- 'will be shadowed by renamed parameter.',
+ 'will be shadowed by renamed parameter.',
expectedContextSearch: 'newName);');
}
@@ -422,7 +423,9 @@ class A {
A({test});
}
''');
- indexUnit('/test2.dart', '''
+ indexUnit(
+ '/test2.dart',
+ '''
import 'test.dart';
main() {
new A(test: 2);
@@ -438,7 +441,9 @@ class A {
A({newName});
}
''');
- assertFileChangeResult('/test2.dart', '''
+ assertFileChangeResult(
+ '/test2.dart',
+ '''
import 'test.dart';
main() {
new A(newName: 2);
@@ -447,7 +452,9 @@ main() {
}
test_createChange_parameter_named_updateHierarchy() async {
- indexUnit('/test2.dart', '''
+ indexUnit(
+ '/test2.dart',
+ '''
library test2;
class A {
void foo({int test: 1}) {
@@ -491,7 +498,9 @@ class C extends A {
}
}
''');
- assertFileChangeResult('/test2.dart', '''
+ assertFileChangeResult(
+ '/test2.dart',
+ '''
library test2;
class A {
void foo({int newName: 1}) {

Powered by Google App Engine
This is Rietveld 408576698