Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

Issue 1266903004: dart2js: Default values for static functions are now inside closures. (in the startup emitter). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
index eedbf5db50fc8405a8a456c61d8a53eaa16f5fab..91d23b29f996e8c50f9218e9e19c62286dd996b1 100644
--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
@@ -700,8 +700,7 @@ class FragmentEmitter {
properties[js.string(namer.requiredParameterField)] =
js.number(method.requiredParameterCount);
properties[js.string(namer.defaultValuesField)] =
- js.js('function() { return #; }',
- _encodeOptionalParameterDefaultValues(method));
+ _encodeOptionalParameterDefaultValues(method);
}
}
@@ -770,7 +769,8 @@ class FragmentEmitter {
List<ConstantValue> defaultValues = method.optionalParameterDefaultValues;
Iterable<js.Expression> elements =
defaultValues.map(generateConstantReference);
- return new js.ArrayInitializer(elements.toList());
+ return js.js('function() { return #; }',
+ new js.ArrayInitializer(elements.toList()));
} else {
Map<String, ConstantValue> defaultValues =
method.optionalParameterDefaultValues;
@@ -785,7 +785,8 @@ class FragmentEmitter {
properties.add(new js.Property(js.string(name),
generateConstantReference(value)));
}
- return new js.ObjectInitializer(properties);
+ return js.js('function() { return #; }',
+ new js.ObjectInitializer(properties));
}
}
« no previous file with comments | « no previous file | sdk/lib/_internal/js_runtime/lib/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698