telemetry: Add a page set for blink's memory usage measurement

tools/perf/measurements/renderer_memory.py

Index: tools/perf/measurements/renderer_memory.py
diff --git a/tools/perf/measurements/renderer_memory.py b/tools/perf/measurements/renderer_memory.py
new file mode 100644
index 0000000000000000000000000000000000000000..8ca39347b516f3a3dbb3d9811993a3c730c51a5d
--- /dev/null
+++ b/tools/perf/measurements/renderer_memory.py
@@ -0,0 +1,75 @@
+# Copyright 2015 The Chromium Authors. All rights reserved.

[Sami, 2015/08/26 10:03:25]

Could you please add a unit test for this measurement? Check the other
measurements for common ways to do this.

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from telemetry.page import page_test
+from telemetry.timeline import tracing_category_filter
+from telemetry.timeline import tracing_options
+from telemetry.timeline.model import TimelineModel
+from telemetry.value import scalar
+
+
+class RendererMemory(page_test.PageTest):

[nednguyen, 2015/08/26 11:50:22]

I am not ok with adding another page_test. Please use timline based measurement
for your metric need. You can ask perezju@ for how.

+  def __init__(self):
+    super(RendererMemory, self).__init__()
+
+  def WillNavigateToPage(self, page, tab):
+    category_filter = tracing_category_filter.TracingCategoryFilter(
+        '-*,blink.console,disabled-by-default-memory-infra')
+    options = tracing_options.TracingOptions()
+    options.enable_chrome_trace = True
+    tab.browser.platform.tracing_controller.Start(options, category_filter, 10)

[Sami, 2015/08/26 10:03:25]

nit: 10s is already the default timeout so you could leave it out from here.

+
+  def CustomizeBrowserOptions(self, options):
+    options.AppendExtraBrowserArgs(
+        ['--enable-memory-benchmarking',

[petrcermak, 2015/08/26 09:33:50]

nit: I think this would be even better with the list starting on line 24 (like
here:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/measure...).

+         '--ignore-certificate-errors',
+         '--no-sandbox'])
+
+  def CleanUpAfterPage(self, _, tab):
+    if tab.browser.platform.tracing_controller.is_tracing_running:
+      tab.browser.platform.tracing_controller.Stop()
+
+  def ValidateAndMeasurePage(self, _, tab, results):
+    if not tab.browser.supports_memory_dumping:
+      self.skipTest('Browser does not support memory dumping, skipping test.')

[petrcermak, 2015/08/26 09:33:50]

I've just investigated this method a little more and it turns out that it's only
available in unittests and not here (I naively assumed that PageTest is a
subclass of Python's unittest.TestCase).

Unfortunately, it seems that even the decorators for enabling and disabling test
cases are only available to actual tests.

So I guess your original assert solution was right after all. Sorry for the
unnecessary extra work :-(

+    guid = tab.browser.DumpMemory()
+    assert guid is not None
+    timeline_data = tab.browser.platform.tracing_controller.Stop()
+    timeline_model = TimelineModel(timeline_data)
+    renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)
+    assert renderer_process is not None
+    dump = self._FindRendererDump(
+        timeline_model, guid, renderer_process.pid)
+    self._AddAllocatorResults(dump, results)
+
+  def _FindRendererDump(self, timeline_model, guid, pid):
+    memory_dumps = list(timeline_model.IterGlobalMemoryDumps())
+    assert len(memory_dumps) == 1
+    assert memory_dumps[0].dump_id == guid
+    renderer_dumps = [
+        dump for dump in memory_dumps[0].IterProcessMemoryDumps()
+        if dump.process.pid == pid]
+    assert len(renderer_dumps) == 1
+    return renderer_dumps[0]
+
+  def _AddAllocatorResults(self, dump, results):
+    usage = dump.GetMemoryUsage()
+
+    def _AddAllocatorStats(category):
+      results.AddValue(scalar.ScalarValue(
+          results.current_page, category, 'MiB',
+          float(usage.get('allocator_' + category, 0.0)) / 1024**2,
+          description='Total memory allocated by ' + category))
+    _AddAllocatorStats('malloc')
+    _AddAllocatorStats('v8')
+    _AddAllocatorStats('blink_gc')
+    _AddAllocatorStats('partition_alloc')
+    _AddAllocatorStats('discardable')
+
+    def _AddMMapStats(category):
+      results.AddValue(scalar.ScalarValue(
+          results.current_page, category, 'MiB',
+          float(usage.get('mmaps_' + category, 0.0)) / 1024**2,
+          description=category))
+    _AddMMapStats('private_dirty')