telemetry: Add a page set for blink's memory usage measurement

tools/perf/measurements/renderer_memory.py

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from telemetry.page import page_test
+from telemetry.timeline import tracing_category_filter
+from telemetry.timeline import tracing_options
+from telemetry.timeline.model import TimelineModel
+from telemetry.value import scalar
+
+
+class RendererMemory(page_test.PageTest):
+  def __init__(self):
+    super(RendererMemory, self).__init__()
+
+  def WillNavigateToPage(self, page, tab):
+    category_filter = tracing_category_filter.TracingCategoryFilter(
+      '-*,blink.console,disabled-by-default-memory-infra')

[petrcermak, 2015/08/26 08:20:18]

This should be indented 4 spaces (+2)

[bashi, 2015/08/26 08:57:34]

Done.

+    options = tracing_options.TracingOptions()
+    options.enable_chrome_trace = True
+    tab.browser.platform.tracing_controller.Start(options, category_filter, 10)
+
+  def CustomizeBrowserOptions(self, options):
+    options.AppendExtraBrowserArgs(
+      ['--enable-memory-benchmarking', '--ignore-certificate-errors',

[petrcermak, 2015/08/26 08:20:18]

This and the next line should be indented 4 spaces (+2)

It might also be a little more readable if you put each flag on a separate line.

[bashi, 2015/08/26 08:57:34]

Done.

+       '--no-sandbox'])
+
+  def CleanUpAfterPage(self, _, tab):
+    if tab.browser.platform.tracing_controller.is_tracing_running:
+      tab.browser.platform.tracing_controller.Stop()
+
+  def ValidateAndMeasurePage(self, _, tab, results):
+    assert tab.browser.supports_memory_dumping

[petrcermak, 2015/08/26 08:20:18]

Any chance this could be replaced with a decorator or using skipTest() in
setUp() instead (see
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...
)?

[bashi, 2015/08/26 08:57:34]

I didn't know that. Thanks! Done.

+    guid = tab.browser.DumpMemory()
+    timeline_data = tab.browser.platform.tracing_controller.Stop()
+    timeline_model = TimelineModel(timeline_data)
+    assert guid is not None

[petrcermak, 2015/08/26 08:20:18]

No reason not to put this right after line 34.

[bashi, 2015/08/26 08:57:34]

Done.

+    renderer_process = timeline_model.GetRendererProcessFromTabId(tab.id)
+    assert renderer_process is not None
+    dump = self._FindRendererDump(
+      timeline_model, guid, renderer_process.pid)

[petrcermak, 2015/08/26 08:20:18]

This should be indented 4 spaces (+2)

[bashi, 2015/08/26 08:57:34]

Done.

+    self._AddAllocatorResults(dump, results)
+
+  def _FindRendererDump(self, timeline_model, guid, pid):
+    memory_dumps = list(timeline_model.IterGlobalMemoryDumps())
+    assert len(memory_dumps) == 1
+    assert memory_dumps[0].dump_id == guid
+    renderer_dumps = [
+      dump for dump in memory_dumps[0].IterProcessMemoryDumps()

[petrcermak, 2015/08/26 08:20:18]

This and the next line should be indented 4 spaces (+2)

[bashi, 2015/08/26 08:57:34]

Done.

+      if dump.process.pid == pid]
+    assert len(renderer_dumps) == 1
+    return renderer_dumps[0]
+
+  def _AddAllocatorResults(self, dump, results):
+    usage = dump.GetMemoryUsage()
+    def _AddAllocatorStats(category):

[petrcermak, 2015/08/26 08:20:18]

nit: I think it would be more readable if you put a blank line above this.

[bashi, 2015/08/26 08:57:34]

Done.

+      results.AddValue(scalar.ScalarValue(
+        results.current_page, category, 'MiB',

[petrcermak, 2015/08/26 08:20:18]

Lines 58-60 and also 69-71 should be indented 4 spaces (+2)

[bashi, 2015/08/26 08:57:33]

Done.

+        float(usage.get('allocator_' + category, 0.0)) / 1024**2,
+        description='Total memory allocated by ' + category))
+    _AddAllocatorStats('malloc')
+    _AddAllocatorStats('v8')
+    _AddAllocatorStats('blink_gc')
+    _AddAllocatorStats('partition_alloc')
+    _AddAllocatorStats('discardable')
+
+    def _AddMMapStats(category):
+      results.AddValue(scalar.ScalarValue(
+        results.current_page, category, 'MiB',
+        float(usage.get('mmaps_' + category, 0.0)) / 1024**2,
+        description=category))
+    _AddMMapStats('private_dirty')