Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1266813002: Enable new media playback UI for clank. (Closed)

Created:
5 years, 4 months ago by liberato (no reviews please)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable new media playback UI for clank. This CL enables the new media UI for clank, and the associated clank-specific behavior to hide volme controls more often to save screen space. Other platforms should not be affected. To revert to the original UI, please revert only this commit. The new UI code itself can be found in https://codereview.chromium.org/1156993013 . The default behavior of that CL, without this one, will be the original UI for all platforms, including clank. BUG=446350, 488625, 487344 Committed: https://crrev.com/2f1a7e0ebd63cbaebba6f72f65df7a9d2557dd09 Cr-Commit-Position: refs/heads/master@{#342627}

Patch Set 1 #

Patch Set 2 : rebased. #

Total comments: 2

Patch Set 3 : moved new media ui enable call. #

Patch Set 4 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/runtime_features.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
liberato (no reviews please)
Please let me know if there's a better way to enable the new media playback ...
5 years, 4 months ago (2015-08-05 16:43:05 UTC) #2
jochen (gone - plz use gerrit)
please send an intent to ship to blink-dev@ before we can land this cl https://codereview.chromium.org/1266813002/diff/20001/content/renderer/render_view_impl.cc ...
5 years, 4 months ago (2015-08-06 07:44:25 UTC) #3
liberato (no reviews please)
there was an intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/liberato/blink-dev/3xs4kKYA_fQ/nZkd_McEEewJ or does this require a separate ...
5 years, 4 months ago (2015-08-06 14:09:39 UTC) #4
jochen (gone - plz use gerrit)
On 2015/08/06 at 14:09:39, liberato wrote: > there was an intent to implement and ship: ...
5 years, 4 months ago (2015-08-06 14:13:10 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-08-06 14:33:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266813002/40001
5 years, 4 months ago (2015-08-06 20:21:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/100320) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-06 20:34:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266813002/60001
5 years, 4 months ago (2015-08-10 15:57:36 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-10 16:01:49 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 16:02:18 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2f1a7e0ebd63cbaebba6f72f65df7a9d2557dd09
Cr-Commit-Position: refs/heads/master@{#342627}

Powered by Google App Engine
This is Rietveld 408576698