Issue 12668009: Revert 188217 "Switch Windows to use the MessagePopupCollection"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12668009: Revert 188217 "Switch Windows to use the MessagePopupCollection" (Closed)

Created:
7 years, 9 months ago by Finnur

Modified:
7 years, 9 months ago

Reviewers:
dewittj

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 188217 "Switch Windows to use the MessagePopupCollection" Looks like it is causing failures in the test touched. See: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%284%29&number=16705 > Switch Windows to use the MessagePopupCollection > > Windows is currently using the old-style MessagePopupBubble which > couldn't display transparent space between the messages. > > r=mukai@chromium.org > TEST=WebNotificationTrayWinTest.* > BUG=181235 > > > Review URL: https://chromiumcodereview.appspot.com/12667018 TBR=dewittj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188317

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -35 lines)			Patch
M	chrome/browser/ui/views/message_center/web_notification_tray_win.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/message_center/web_notification_tray_win.cc	View	5 chunks	+21 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/message_center/web_notification_tray_win_browsertest.cc	View	4 chunks	+6 lines, -9 lines	0 comments	Download
M	ui/message_center/message_center.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/message_center/views/message_popup_collection.cc	View	2 chunks	+3 lines, -15 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r188317.