Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1266743002: [turbofan] Fix invalid access to Parameter index. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix invalid access to Parameter index. A Parameter operator contains a ParameterInfo payload, not an int payload, so the OpParameter<int> cast is invalid (and only worked by coincidence currently). BUG=chromium:515215 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/efab0b74ddfe44ef03cad6822910f178a1055aaa Cr-Commit-Position: refs/heads/master@{#29919}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/compiler/typer.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-07-30 06:01:13 UTC) #1
Benedikt Meurer
Hey Yang, Simple fix. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-07-30 06:01:35 UTC) #2
Yang
On 2015/07/30 06:01:35, Benedikt Meurer wrote: > Hey Yang, > > Simple fix. Please take ...
5 years, 4 months ago (2015-07-30 06:03:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266743002/1
5 years, 4 months ago (2015-07-30 06:28:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 09:16:15 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:16:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efab0b74ddfe44ef03cad6822910f178a1055aaa
Cr-Commit-Position: refs/heads/master@{#29919}

Powered by Google App Engine
This is Rietveld 408576698