Process Public-Key-Pin-Report-Only headers

net/url_request/url_request_http_job.cc

Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 019a0a76caec400b52e2a422923f29a0b3105a69..f165fcbb9d922cd3bbe23deb29579cee04372a3b 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -892,6 +892,11 @@ void URLRequestHttpJob::ProcessPublicKeyPinsHeader() {
   std::string value;
   if (headers->EnumerateHeader(NULL, "Public-Key-Pins", &value))

[Ryan Sleevi, 2015/07/30 01:52:17]

Bonus points for the subtle C++11-ization of changing this and line 895 to
nullptr

[estark, 2015/07/31 00:49:44]

Done.

     security_state->AddHPKPHeader(request_info_.url.host(), value, ssl_info);
+  if (headers->EnumerateHeader(NULL, "Public-Key-Pins-Report-Only", &value)) {
+    security_state->ProcessHPKPReportOnlyHeader(
+        HostPortPair(request_info_.url.host(), request_info_.url.IntPort()),

[Ryan Sleevi, 2015/07/30 01:52:17]

You really want HostPortPair::FromURL(request_info_.url). The BUG here is you're
using IntPort rather than EffectiveIntPort, for example, and also missing the
narrowing cast.

[estark, 2015/07/31 00:49:44]

Done.

+        value, ssl_info);
+  }
 }
 
 void URLRequestHttpJob::OnStartCompleted(int result) {