Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6814)

Unified Diff: chrome/browser/chrome_service_worker_browsertest.cc

Issue 1266713007: Net: Stop treating partial HTTP headers as a valid response. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix < 8-byte HTTP/0.9 responses over HTTPS Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_service_worker_browsertest.cc
diff --git a/chrome/browser/chrome_service_worker_browsertest.cc b/chrome/browser/chrome_service_worker_browsertest.cc
index 3a2042085e20dcc91310673aeec4c55d148bf720..82a2f55d98c1f033e6f95294fd294be43d1a0d33 100644
--- a/chrome/browser/chrome_service_worker_browsertest.cc
+++ b/chrome/browser/chrome_service_worker_browsertest.cc
@@ -53,7 +53,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,
CanShutDownWithRegisteredServiceWorker) {
WriteFile(FILE_PATH_LITERAL("service_worker.js"), "");
WriteFile(FILE_PATH_LITERAL("service_worker.js.mock-http-headers"),
- "HTTP/1.1 200 OK\nContent-Type: text/javascript");
+ "HTTP/1.0 200 OK\nContent-Type: text/javascript\n");
embedded_test_server()->ServeFilesFromDirectory(service_worker_dir_.path());
ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
@@ -80,7 +80,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,
CanCloseIncognitoWindowWithServiceWorkerController) {
WriteFile(FILE_PATH_LITERAL("service_worker.js"), "");
WriteFile(FILE_PATH_LITERAL("service_worker.js.mock-http-headers"),
- "HTTP/1.1 200 OK\nContent-Type: text/javascript");
davidben 2015/07/31 21:32:50 Ick. Why didn't they check in these files?
mmenke 2015/07/31 21:45:36 I have no idea.
+ "HTTP/1.0 200 OK\nContent-Type: text/javascript\n");
WriteFile(FILE_PATH_LITERAL("test.html"), "");
embedded_test_server()->ServeFilesFromDirectory(service_worker_dir_.path());
« no previous file with comments | « no previous file | net/http/http_network_transaction_unittest.cc » ('j') | net/http/http_network_transaction_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698