Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: src/interpreter/interpreter.cc

Issue 1266713004: [Intepreter] Addition of BytecodeArrayBuilder and accumulator based bytecodes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move generator to a separate CL and patch set 1 comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index ddb87056edcb2eabccbd37e21a0d53ebaee6c05c..93fbc1f49e8eb34b630db3eeb6d68487cca778ec 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -48,21 +48,109 @@ void Interpreter::Initialize(bool create_heap_objects) {
}
-// LoadLiteral0 <dst>
+// LdaZero <dst>
rmcilroy 2015/07/31 09:56:19 Remove <dst>
oth 2015/07/31 11:20:59 Done.
//
// Load literal '0' into the destination register.
rmcilroy 2015/07/31 09:56:19 update comment /s/destination/accumulator/ and rem
oth 2015/07/31 11:20:59 Done.
-void Interpreter::DoLoadLiteral0(compiler::InterpreterAssembler* assembler) {
+void Interpreter::DoLdaZero(compiler::InterpreterAssembler* assembler) {
Node* register_index = __ BytecodeOperand(0);
__ StoreRegister(__ NumberConstant(0), register_index);
__ Dispatch();
}
-// LoadSmi8 <dst>, <imm8>
+// LdaSmi8 <dst>, <imm8>
rmcilroy 2015/07/31 09:56:19 remove <dst>
oth 2015/07/31 11:20:59 Done.
//
// Load an 8-bit integer literal into destination register as a Smi.
rmcilroy 2015/07/31 09:56:19 /s/destination/acumulator
oth 2015/07/31 11:20:59 Done.
-void Interpreter::DoLoadSmi8(compiler::InterpreterAssembler* assembler) {
- // TODO(rmcilroy) Convert an 8-bit integer to a Smi.
+void Interpreter::DoLdaSmi8(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement 8-bit integer to SMI promotion.
+}
+
+
+// LdaUndefined
+//
+// Load Undefined into the accumulator.
+void Interpreter::DoLdaUndefined(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// LdaNull
+//
+// Load Null into the accumulator.
+void Interpreter::DoLdaNull(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// LdaTheHole
+//
+// Load TheHole into the accumulator.
+void Interpreter::DoLdaTheHole(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// LdaTrue
+//
+// Load True into the accumulator.
+void Interpreter::DoLdaTrue(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// LdaFalse
+//
+// Load False into the accumulator.
+void Interpreter::DoLdaFalse(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// Ldar <src>
+//
+// Load accumulator with value from register <src>.
+void Interpreter::DoLdar(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// Star <dst>
+//
+// Store accumulator to register <dst>.
+void Interpreter::DoStar(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// Add <src>
+//
+// Add register <src> to accumulator.
+void Interpreter::DoAdd(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// Sub <src>
+//
+// Subtract register <src> from accumulator.
+void Interpreter::DoSub(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
+}
+
+
+// Mul <src>
+//
+// Multiply accumulator by register <src>.
+void Interpreter::DoMul(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement add register to accumulator.
+}
+
+
+// Div <src>
+//
+// Divide register <src> by accumulator.
+void Interpreter::DoDiv(compiler::InterpreterAssembler* assembler) {
+ // TODO(rmcilroy) Implement.
}

Powered by Google App Engine
This is Rietveld 408576698