[Intepreter] Addition of BytecodeArrayBuilder and accumulator based bytecodes.

src/interpreter/bytecodes.h

Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index b4c0d9c4446b7eda2ac1a99a683d29e018c519b2..977751fd8e92a7e8fa4fffee7878a887955cc2e8 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -22,9 +22,20 @@ namespace interpreter {
   V(Reg)
 
 // The list of bytecodes which are interpreted by the interpreter.
-#define BYTECODE_LIST(V)                             \
-  V(LoadLiteral0, OperandType::kReg)                 \
-  V(LoadSmi8, OperandType::kReg, OperandType::kImm8) \
+#define BYTECODE_LIST(V)              \
+  V(LoadLiteral0, OperandType::kNone) \
+  V(LoadSmi8, OperandType::kImm8)     \

[rmcilroy, 2015/07/30 10:12:25]

nit - can we update the bytecodes above to be in the same form as below (i.e.,
Ldr0, LdrSmi8 and also add Lda0 and LdaSmi8?)

Also, could we split up the list with some heading comments (e.g., Constants,
Register moves, Binary Ops, etc.). And maybe add comments for some of the more
difficult to parse operations (e.g, Ldar - "Loads accumulator from a register.")

[oth, 2015/07/30 15:38:42]

Done.

[oth, 2015/07/30 15:38:43]

The pattern has been to add instructions as needed. Constant loads are to the
accumulator at the moment. Probably better to tweak instructions in the
generator patch.

+  V(LdaUndefined, OperandType::kNone) \
+  V(LdaNull, OperandType::kNone)      \
+  V(LdaTheHole, OperandType::kNone)   \
+  V(LdaTrue, OperandType::kNone)      \
+  V(LdaFalse, OperandType::kNone)     \
+  V(Ldar, OperandType::kReg)          \
+  V(Stra, OperandType::kReg)          \
+  V(Add, OperandType::kReg)           \
+  V(Sub, OperandType::kReg)           \
+  V(Mul, OperandType::kReg)           \
+  V(Div, OperandType::kReg)           \
   V(Return, OperandType::kNone)