[Intepreter] Addition of BytecodeArrayBuilder and accumulator based bytecodes.

src/interpreter/bytecode-array-builder.cc

Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c9d1560df21a8ddce9ee118f363b228bb8720148
--- /dev/null
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -0,0 +1,220 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/interpreter/bytecode-array-builder.h"
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+BytecodeArrayBuilder::BytecodeArrayBuilder(Isolate* isolate)
+    : isolate_(isolate),
+      bytecode_generated_(false),
+      local_register_count_(-1),
+      temporary_register_count_(0),
+      temporary_register_next_(0) {}
+
+
+void BytecodeArrayBuilder::set_locals_count(int number_of_locals) {
+  local_register_count_ = number_of_locals;
+  temporary_register_next_ = local_register_count_;
+}
+
+
+int BytecodeArrayBuilder::locals_count() const { return local_register_count_; }
+
+Handle<BytecodeArray> BytecodeArrayBuilder::ToBytecodeArray() {
+  DCHECK_EQ(bytecode_generated_, false);
+  DCHECK_GE(local_register_count_, 0);
+  int bytecode_size = static_cast<int>(bytecodes_.size());
+  int register_count = local_register_count_ + temporary_register_count_;
+  int frame_size = register_count * kPointerSize;
+  Handle<BytecodeArray> output = isolate_->factory()->NewBytecodeArray(
+      bytecode_size, &bytecodes_.front(), frame_size);
+  bytecode_generated_ = true;
+  return output;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::BinaryOperation(Token::Value binop,
+                                                            int reg) {
+  Output(BytecodeForBinaryOperation(binop), reg);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadLiteral(
+    v8::internal::Smi* smi) {
+  int32_t raw_smi = smi->value();
+  if (raw_smi == 0) {
+    Output(Bytecode::kLdaZero);
+  } else if (raw_smi > -128 && raw_smi <= 128) {
+    Output(Bytecode::kLdaSmi8, static_cast<uint8_t>(raw_smi));
+  } else {
+    // TODO(oth): Put Smi in constant pool.
+    UNIMPLEMENTED();
+  }
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadUndefined() {
+  Output(Bytecode::kLdaUndefined);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadNull() {
+  Output(Bytecode::kLdaNull);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadTheHole() {
+  Output(Bytecode::kLdaTheHole);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadTrue() {
+  Output(Bytecode::kLdaTrue);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadFalse() {
+  Output(Bytecode::kLdaFalse);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::LoadAccumulatorWithRegister(
+    int reg) {
+  Output(Bytecode::kLdar, reg);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::StoreAccumulatorInRegister(
+    int reg) {
+  Output(Bytecode::kStar, reg);
+  return *this;
+}
+
+
+BytecodeArrayBuilder& BytecodeArrayBuilder::Return() {
+  Output(Bytecode::kReturn);
+  return *this;
+}
+
+
+int BytecodeArrayBuilder::BorrowTemporaryRegister() {
+  DCHECK_GE(local_register_count_, 0);
+  int temporary_register = temporary_register_next_++;
+  int count = temporary_register_next_ - local_register_count_;
+  if (count > temporary_register_count_) {
+    temporary_register_count_ = count;
+  }
+  return temporary_register;
+}
+
+
+void BytecodeArrayBuilder::ReturnTemporaryRegister(int reg) {
+  DCHECK_EQ(reg, temporary_register_next_ - 1);
+  temporary_register_next_ = reg;
+}
+
+
+bool BytecodeArrayBuilder::OperandIsValid(Bytecode bytecode, int operand_index,
+                                          uint8_t operand_value) const {
+  OperandType operand_type = Bytecodes::GetOperandType(bytecode, operand_index);
+  switch (operand_type) {
+    case OperandType::kNone:
+      return false;
+    case OperandType::kImm8:
+      return true;
+    case OperandType::kReg:
+      return operand_value < temporary_register_next_;
+  }
+  UNREACHABLE();
+  return false;
+}
+
+
+void BytecodeArrayBuilder::Output(Bytecode bytecode, uint8_t operand0,
+                                  uint8_t operand1, uint8_t operand2) {
+  DCHECK_EQ(Bytecodes::NumberOfOperands(bytecode), 3);

[picksi, 2015/08/03 11:06:01]

This function does a DCHECK_EQ, the following functions use DCHECK, is this
intentional?

[oth, 2015/08/03 15:39:59]

Fixed, thanks!

+  DCHECK(OperandIsValid(bytecode, 0, operand0) &&
+         OperandIsValid(bytecode, 1, operand1) &&
+         OperandIsValid(bytecode, 2, operand2));
+  bytecodes_.push_back(Bytecodes::ToByte(bytecode));
+  bytecodes_.push_back(operand0);
+  bytecodes_.push_back(operand1);
+  bytecodes_.push_back(operand2);
+}
+
+
+void BytecodeArrayBuilder::Output(Bytecode bytecode, uint8_t operand0,
+                                  uint8_t operand1) {
+  DCHECK(Bytecodes::NumberOfOperands(bytecode) == 2);
+  DCHECK(OperandIsValid(bytecode, 0, operand0) &&
+         OperandIsValid(bytecode, 1, operand1));
+  bytecodes_.push_back(Bytecodes::ToByte(bytecode));
+  bytecodes_.push_back(operand0);
+  bytecodes_.push_back(operand1);
+}
+
+
+void BytecodeArrayBuilder::Output(Bytecode bytecode, uint8_t operand0) {
+  DCHECK(Bytecodes::NumberOfOperands(bytecode) == 1);
+  DCHECK(OperandIsValid(bytecode, 0, operand0));
+  bytecodes_.push_back(Bytecodes::ToByte(bytecode));
+  bytecodes_.push_back(operand0);
+}
+
+
+void BytecodeArrayBuilder::Output(Bytecode bytecode) {
+  DCHECK(Bytecodes::NumberOfOperands(bytecode) == 0);
+  bytecodes_.push_back(Bytecodes::ToByte(bytecode));
+}
+
+
+// static
+Bytecode BytecodeArrayBuilder::BytecodeForBinaryOperation(Token::Value op) {
+  switch (op) {
+    case Token::Value::ADD:
+      return Bytecode::kAdd;
+    case Token::Value::SUB:
+      return Bytecode::kSub;
+    case Token::Value::MUL:
+      return Bytecode::kMul;
+    case Token::Value::DIV:
+      return Bytecode::kDiv;
+    default:
+      UNIMPLEMENTED();
+      return static_cast<Bytecode>(-1);

[picksi, 2015/08/03 11:06:01]

Should we have an error ByteCode that is -1, instead of casting it here?

[oth, 2015/08/03 15:39:59]

In this instance, it's not recoverable error. The failure mode of
UNIMPLEMENTED() is a fatal which makes the source easy to find. There are more
operands to come here.

The test for the BytecodeArrayBuilder checks all bytecodes can be generated by
the builder. A function in the builder generating an invalid bytecode would
probably get used.

+  }
+}
+
+
+TemporaryRegisterScope::TemporaryRegisterScope(BytecodeArrayBuilder* builder)
+    : builder_(builder), count_(0), register_(-1) {}
+
+
+TemporaryRegisterScope::~TemporaryRegisterScope() {
+  while (count_-- != 0) {
+    builder_->ReturnTemporaryRegister(register_--);
+  }
+}
+
+
+int TemporaryRegisterScope::NewRegister() {
+  count_++;
+  register_ = builder_->BorrowTemporaryRegister();
+  return register_;
+}
+
+}  // namespace interpreter
+}  // namespace internal
+}  // namespace v8