[Intepreter] Addition of BytecodeArrayBuilder and accumulator based bytecodes.

src/interpreter/interpreter.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter.h"
 
 #include "src/compiler.h"
 #include "src/compiler/interpreter-assembler.h"
 #include "src/factory.h"
+#include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/bytecodes.h"
 #include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
 using compiler::Node;
 #define __ assembler->
 
@@ skipping 17 matching lines @@
     Do##Name(&assembler);                                           \
     Handle<Code> code = assembler.GenerateCode();                   \
     handler_table->set(static_cast<int>(Bytecode::k##Name), *code); \
   }
     BYTECODE_LIST(GENERATE_CODE)
 #undef GENERATE_CODE
   }
 }
 
 
+// static
+bool Interpreter::MakeBytecode(CompilationInfo* info) {
+  Handle<SharedFunctionInfo> shared_info =
+      Compiler::GetSharedFunctionInfo(info->function(), info->script(), info);
+  BytecodeGenerator generator(info->isolate(), info->zone());
+  Handle<BytecodeArray> bytecodes = generator.MakeBytecode(info);
+  bytecodes->Print();

[rmcilroy, 2015/07/30 10:12:25]

nit - add a flag for printing the bytecodes (e.g.,
FLAG_trace_ignition_bytecodes, and possibly also rename FLAG_trace_ignition to
FLAG_trace_ignition_handler_generation or similar).

[oth, 2015/07/30 15:38:43]

Done in the bytecode generation CL.

+
+  CHECK(shared_info->function_data()->IsUndefined());
+  shared_info->set_function_data(*bytecodes);
+  // info->SetCode(info->isolate()->builtins()->InterpreterEntryTrampoline());

[rmcilroy, 2015/07/30 10:12:25]

Just do this?

[oth, 2015/07/30 15:38:43]

Other CL.

+  info->EnsureFeedbackVector();
+  return true;
+}
+
+
 // LoadLiteral0 <dst>
 //
 // Load literal '0' into the destination register.
 void Interpreter::DoLoadLiteral0(compiler::InterpreterAssembler* assembler) {
   Node* register_index = __ BytecodeOperand(0);
   __ StoreRegister(__ NumberConstant(0), register_index);
   __ Dispatch();
 }
 
 
 // LoadSmi8 <dst>, <imm8>
 //
 // Load an 8-bit integer literal into destination register as a Smi.
 void Interpreter::DoLoadSmi8(compiler::InterpreterAssembler* assembler) {
-  // TODO(rmcilroy) Convert an 8-bit integer to a Smi.
+  // TODO(rmcilroy) Implement 8-bit integer to SMI promotion.
 }
 
 
+// LdaUndefined
+//
+// Load Undefined into the accumulator.
+void Interpreter::DoLdaUndefined(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// LdaNull
+//
+// Load Null into the accumulator.
+void Interpreter::DoLdaNull(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// LdaTheHole
+//
+// Load TheHole into the accumulator.
+void Interpreter::DoLdaTheHole(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// LdaTrue
+//
+// Load True into the accumulator.
+void Interpreter::DoLdaTrue(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// LdaFalse
+//
+// Load False into the accumulator.
+void Interpreter::DoLdaFalse(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// Ldar <src>
+//
+// Load accumulator with value from register <src>.
+void Interpreter::DoLdar(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// Stra <dst>
+//
+// Store accumulator to register <dst>.
+void Interpreter::DoStra(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// Add <src>
+//
+// Add register <src> to accumulator.
+void Interpreter::DoAdd(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// Sub <src>
+//
+// Subtract register <src> from accumulator.
+void Interpreter::DoSub(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
+// Mul <src>
+//
+// Multiply accumulator by register <src>.
+void Interpreter::DoMul(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement add register to accumulator.
+}
+
+
+// Div <src>
+//
+// Divide register <src> by accumulator.
+void Interpreter::DoDiv(compiler::InterpreterAssembler* assembler) {
+  // TODO(rmcilroy) Implement.
+}
+
+
 // Return
 //
 // Return the value in register 0.
 void Interpreter::DoReturn(compiler::InterpreterAssembler* assembler) {
   // TODO(rmcilroy) Jump to exit trampoline.
 }
 
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8