Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266713003: Clean up some StyleBuilder property application code (Closed)

Created:
5 years, 4 months ago by Timothy Loh
Modified:
5 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up some StyleBuilder property application code This patch cleans up StyleBuilder property application for several properties, mostly removing defensive checks about CSSValue types and replacing them with assertions, mostly from the toCSSFooValue macros Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -103 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 4 chunks +21 lines, -40 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 4 chunks +8 lines, -43 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 5 chunks +3 lines, -16 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
5 years, 4 months ago (2015-07-30 07:03:54 UTC) #2
alancutter (OOO until 2018)
lgtm
5 years, 4 months ago (2015-07-30 07:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266713003/1
5 years, 4 months ago (2015-07-30 07:15:51 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 07:58:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199714

Powered by Google App Engine
This is Rietveld 408576698