Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1266693005: [Chromecast] Allow |enable_pepper_cdms| to be set in gn args. (Closed)

Created:
5 years, 4 months ago by slan
Modified:
5 years, 4 months ago
Reviewers:
alokp, brettw, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Allow |enable_pepper_cdms| to be set in gn args. Chromecast builds need to explicitly set |enable_browser_cdms| to true and |enable_pepper_cdms| to false. Rather than introduce a global is_chromecast variable, as we have in GYP, allow |enable_pepper_cdms| to be set in args.gn. BUG= b/17615224 Committed: https://crrev.com/9bacb78d7d0a453ff5d23df7fd30b7b75cded17d Cr-Commit-Position: refs/heads/master@{#341776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/config/features.gni View 2 chunks +4 lines, -2 lines 0 comments Download
M chromecast/build/args.gn View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
slan
My goal is to avoid an "is_chromecast" variable. Here the corresponding GYP change: https://chromium.googlesource.com/chromium/src/+/e4513848535ec9ad29c40320ac2e2aa6551b5423 PTAL.
5 years, 4 months ago (2015-08-04 17:23:56 UTC) #2
brettw
lgtm
5 years, 4 months ago (2015-08-04 17:30:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266693005/1
5 years, 4 months ago (2015-08-04 17:47:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-04 18:50:06 UTC) #7
gunsch
lgtm
5 years, 4 months ago (2015-08-04 19:43:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266693005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266693005/1
5 years, 4 months ago (2015-08-04 20:05:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 20:13:03 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 20:13:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bacb78d7d0a453ff5d23df7fd30b7b75cded17d
Cr-Commit-Position: refs/heads/master@{#341776}

Powered by Google App Engine
This is Rietveld 408576698