content: Populate WebPointerProperties with stylus details from ui::MouseEvent

content/browser/renderer_host/web_input_event_aura.cc

Index: content/browser/renderer_host/web_input_event_aura.cc
diff --git a/content/browser/renderer_host/web_input_event_aura.cc b/content/browser/renderer_host/web_input_event_aura.cc
index bbad8c7729de5201641ca854491549d3ff0f6816..152eb4c82654648d48973ac54446f15be9ef1ba8 100644
--- a/content/browser/renderer_host/web_input_event_aura.cc
+++ b/content/browser/renderer_host/web_input_event_aura.cc
@@ -48,6 +48,23 @@ blink::WebInputEvent::Modifiers DomCodeToWebInputEventModifiers(
   return static_cast<blink::WebInputEvent::Modifiers>(0);
 }
 
+blink::WebPointerProperties::PointerType EventPointerTypeToWebPointerType(
+    ui::EventPointerType pointer_type) {
+  switch (pointer_type) {
+    case ui::EventPointerType::POINTER_TYPE_UNKNOWN:
+      return blink::WebPointerProperties::PointerType::PointerTypeUnknown;
+    case ui::EventPointerType::POINTER_TYPE_MOUSE:
+      return blink::WebPointerProperties::PointerType::PointerTypeMouse;
+    case ui::EventPointerType::POINTER_TYPE_PEN:
+      return blink::WebPointerProperties::PointerType::PointerTypePen;
+    case ui::EventPointerType::POINTER_TYPE_TOUCH:
+      return blink::WebPointerProperties::PointerType::PointerTypeTouch;
+    default:

[sadrul, 2015/08/26 19:05:30]

Remove default case.

[robert.bradford, 2015/08/27 14:54:51]

Done.

+      NOTREACHED() << "Unexpected EventPointerType";
+      return blink::WebPointerProperties::PointerType::PointerTypeUnknown;
+  }
+}
+
 }  // namespace
 
 #if defined(OS_WIN)
@@ -379,6 +396,12 @@ blink::WebMouseEvent MakeWebMouseEventFromAuraEvent(
       break;
   }
 
+  webkit_event.tiltX = roundf(event.pointer_details().tilt_x());

[sadrul, 2015/08/26 19:05:30]

Why roundf()?

What is the type of tiltX? (is there a blink CL that still hasn't landed?)

[robert.bradford, 2015/08/27 14:54:51]

The class is here
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
which is one of the superclasses of WebMouseEvent. The type of tiltX is int
(which matches the spec, where I think it is a bit odd that it uses just whole
degrees); I think rounding away is probably a better solution than truncating.

+  webkit_event.tiltY = roundf(event.pointer_details().tilt_y());
+  webkit_event.force = event.pointer_details().force();
+  webkit_event.pointerType =
+      EventPointerTypeToWebPointerType(event.pointer_details().pointer_type());
+
   return webkit_event;
 }
 
@@ -402,6 +425,12 @@ blink::WebMouseWheelEvent MakeWebMouseWheelEventFromAuraEvent(
   webkit_event.wheelTicksX = webkit_event.deltaX / kPixelsPerTick;
   webkit_event.wheelTicksY = webkit_event.deltaY / kPixelsPerTick;
 
+  webkit_event.tiltX = roundf(event.pointer_details().tilt_x());
+  webkit_event.tiltY = roundf(event.pointer_details().tilt_y());
+  webkit_event.force = event.pointer_details().force();
+  webkit_event.pointerType =
+      EventPointerTypeToWebPointerType(event.pointer_details().pointer_type());
+
   return webkit_event;
 }