src/gpu/effects/GrConvolutionEffect.h - Issue 1266633003: Added registerChild; transforms, textures, glKey automatically handled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConvolutionEffect.h

Issue 1266633003: Added registerChild; transforms, textures, glKey automatically handled. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: refactored to onGetGLProcessorKey; removed emitSamplers specialized template; fixed nits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrConvolutionEffect.h

diff --git a/src/gpu/effects/GrConvolutionEffect.h b/src/gpu/effects/GrConvolutionEffect.h

index 066da1975c41d621c55dc3dd0a171203d2613b1d..e65c4c43c94d4e2341d7dd0489048bf791087398 100644

--- a/src/gpu/effects/GrConvolutionEffect.h

+++ b/src/gpu/effects/GrConvolutionEffect.h

@@ -63,8 +63,6 @@ public:

const char* name() const override { return "Convolution"; }

- void getGLProcessorKey(const GrGLSLCaps&, GrProcessorKeyBuilder*) const override;

GrGLFragmentProcessor* createGLInstance() const override;

enum {

@@ -100,6 +98,8 @@ private:

bool useBounds,

float bounds[2]);

+ void onGetGLProcessorKey(const GrGLSLCaps&, GrProcessorKeyBuilder*) const override;

bool onIsEqual(const GrFragmentProcessor&) const override;

void onComputeInvariantOutput(GrInvariantOutput* inout) const override {

« no previous file with comments | « src/gpu/effects/GrConvexPolyEffect.cpp ('k') | src/gpu/effects/GrConvolutionEffect.cpp » ('j') | no next file with comments »