Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 126663003: Mojo: DataPipe: Test "all or nothing" mode. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: DataPipe: Test "all or nothing" mode. (Except for two-phase read/writes in "may discard" mode, which isn't supported yet.) R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243450

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -2 lines) Patch
M mojo/system/local_data_pipe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/local_data_pipe_unittest.cc View 1 1 chunk +332 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-07 23:39:23 UTC) #1
DaveMoore
lgtm https://codereview.chromium.org/126663003/diff/1/mojo/system/local_data_pipe_unittest.cc File mojo/system/local_data_pipe_unittest.cc (right): https://codereview.chromium.org/126663003/diff/1/mojo/system/local_data_pipe_unittest.cc#newcode603 mojo/system/local_data_pipe_unittest.cc:603: num_bytes = 0u; Nit: this would be better ...
6 years, 11 months ago (2014-01-07 23:51:01 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/126663003/diff/1/mojo/system/local_data_pipe_unittest.cc File mojo/system/local_data_pipe_unittest.cc (right): https://codereview.chromium.org/126663003/diff/1/mojo/system/local_data_pipe_unittest.cc#newcode603 mojo/system/local_data_pipe_unittest.cc:603: num_bytes = 0u; On 2014/01/07 23:51:01, DaveMoore wrote: ...
6 years, 11 months ago (2014-01-07 23:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/126663003/70001
6 years, 11 months ago (2014-01-08 00:03:07 UTC) #4
viettrungluu
6 years, 11 months ago (2014-01-08 00:38:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r243450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698