Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1266603002: [turbofan] Factor C call descriptor building into compiler/c-linkage.cc. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Factor C call descriptor building into compiler/c-linkage.cc. This is the first step in cutting the Gordian linkage/linkage-impl knot. This basically changes the axis along which we organize call descriptor building logic from having platform-specific files dedicated to all call descriptor types to having call-descriptor-type-specific files that have The next step is to factor the JS, code stub, and runtime call descriptors similarly, dumping them into: compiler/js-linkage.cc compiler/runtime-linkage.cc compiler/code-stub-linkage.cc or, alternatively, all of them just into compiler/js-linkage.cc. This also anticipates a wasm-linkage.cc file in the future. R=bmeurer@chromium.org,danno@chromium.org BUG= Committed: https://crrev.com/c215c9569ee362bdd4b151499b6c5f5822bb4e45 Cr-Commit-Position: refs/heads/master@{#29931}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Switch to macros. #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -211 lines) Patch
M src/compiler/arm/linkage-arm.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 2 chunks +0 lines, -23 lines 0 comments Download
A src/compiler/c-linkage.cc View 1 2 3 1 chunk +245 lines, -0 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M src/compiler/ppc/linkage-ppc.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 3 chunks +0 lines, -41 lines 0 comments Download
M src/compiler/x87/linkage-x87.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
titzer
5 years, 4 months ago (2015-07-29 15:03:10 UTC) #1
Benedikt Meurer
This approach will not work because you add new static initializers until uniform initialization and ...
5 years, 4 months ago (2015-07-30 06:35:14 UTC) #2
titzer
On 2015/07/30 06:35:14, Benedikt Meurer wrote: > This approach will not work because you add ...
5 years, 4 months ago (2015-07-30 07:12:40 UTC) #3
titzer
On 2015/07/30 07:12:40, titzer wrote: > On 2015/07/30 06:35:14, Benedikt Meurer wrote: > > This ...
5 years, 4 months ago (2015-07-30 09:54:39 UTC) #4
Benedikt Meurer
Template magic to macro magic transition :-) LGTM.
5 years, 4 months ago (2015-07-30 12:34:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266603002/50013 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266603002/50013
5 years, 4 months ago (2015-07-30 12:34:49 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:50013)
5 years, 4 months ago (2015-07-30 12:36:20 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:36:34 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c215c9569ee362bdd4b151499b6c5f5822bb4e45
Cr-Commit-Position: refs/heads/master@{#29931}

Powered by Google App Engine
This is Rietveld 408576698