Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266593002: Move headers with no dependencies. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move headers with no dependencies. C.f. https://codereview.chromium.org/1261013003/ BUG=skia:4126 Will follow up with two more CLs if this works: - one moving SkRecords.h - one moving SkMiniRecorder.h No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/117842223bd13325b6da26110d80e0590c1a742b Committed: https://skia.googlesource.com/skia/+/22355c4f404becfdc39b962c15533cef9f45615c

Patch Set 1 #

Patch Set 2 : SkRecords.h #

Patch Set 3 : everything not involving SkPathPriv.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -105 lines) Patch
M include/gpu/gl/SkGLContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + include/private/SkFunction.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkGpuFenceSync.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 1 chunk +1 line, -1 line 0 comments Download
D src/core/SkFunction.h View 1 chunk +0 lines, -75 lines 0 comments Download
D src/gpu/SkGpuFenceSync.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
mtklein_C
5 years, 4 months ago (2015-07-29 15:01:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266593002/20001
5 years, 4 months ago (2015-07-29 15:05:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-29 15:12:41 UTC) #6
bungeman-skia
lgtm
5 years, 4 months ago (2015-07-29 15:15:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266593002/20001
5 years, 4 months ago (2015-07-29 15:15:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1404)
5 years, 4 months ago (2015-07-29 15:16:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266593002/20001
5 years, 4 months ago (2015-07-29 15:17:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/117842223bd13325b6da26110d80e0590c1a742b
5 years, 4 months ago (2015-07-29 15:18:37 UTC) #16
mtklein
Trying again with everything that doesn't involve SkPathPriv.h.
5 years, 4 months ago (2015-07-29 18:01:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266593002/40001
5 years, 4 months ago (2015-07-29 18:02:20 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 18:10:49 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/22355c4f404becfdc39b962c15533cef9f45615c

Powered by Google App Engine
This is Rietveld 408576698