Fix the links in the media bubble pointing to the media UI.

chrome/browser/ui/content_settings/content_setting_bubble_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/content_settings/content_setting_bubble_model.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 560 matching lines @@
 // The model of the content settings bubble for media settings.
 class ContentSettingMediaStreamBubbleModel
     : public ContentSettingTitleAndLinkModel {
  public:
   ContentSettingMediaStreamBubbleModel(Delegate* delegate,
                                        WebContents* web_contents,
                                        Profile* profile);
 
   ~ContentSettingMediaStreamBubbleModel() override;
 
+  void OnManageLinkClicked() override;
+
  private:
+  // Helper functions to check if this bubble was invoked for microphone,
+  // camera, or both devices.
+  bool MicrophoneAccessed() const;
+  bool CameraAccessed() const;
+
   void SetTitle();
   // Sets the data for the radio buttons of the bubble.
   void SetRadioGroup();
   // Sets the data for the media menus of the bubble.
   void SetMediaMenus();
+  // Set the settings management link.
+  void SetManageLink();
   void SetCustomLink();
   // Updates the camera and microphone setting with the passed |setting|.
   void UpdateSettings(ContentSetting setting);
   // Updates the camera and microphone default device with the passed |type|
   // and device.
   void UpdateDefaultDeviceForType(content::MediaStreamType type,
                                   const std::string& device);
 
   // ContentSettingBubbleModel implementation.
   void OnRadioClicked(int radio_index) override;
@@ skipping 10 matching lines @@
 };
 
 ContentSettingMediaStreamBubbleModel::ContentSettingMediaStreamBubbleModel(
     Delegate* delegate,
     WebContents* web_contents,
     Profile* profile)
     : ContentSettingTitleAndLinkModel(
           delegate, web_contents, profile, CONTENT_SETTINGS_TYPE_MEDIASTREAM),
       selected_item_(0),
       state_(TabSpecificContentSettings::MICROPHONE_CAMERA_NOT_ACCESSED) {
+  // TODO(msramek): Every bubble is tied to a particular content setting.
+  // The media bubble has three states - mic only, camera only, and both.
+  // However, it is always tied to the deprecated MEDIASTREAM setting. Refactor
+  // this so that it refers to the MIC setting for microphone and CAMERA
+  // setting for camera to reduce the duplication of code in practically every
+  // method. Furthermore, it should be possible not to tie the bubble to any
+  // particular content setting type, as we still need the bubble for both
+  // camera and microphone, but should not use the deprecated MEDIASTREAM
+  // setting.
+
   DCHECK(profile);
   // Initialize the content settings associated with the individual radio
   // buttons.
   radio_item_setting_[0] = CONTENT_SETTING_ASK;
   radio_item_setting_[1] = CONTENT_SETTING_BLOCK;
 
   TabSpecificContentSettings* content_settings =
       TabSpecificContentSettings::FromWebContents(web_contents);
   state_ = content_settings->GetMicrophoneCameraState();
-  DCHECK(state_ & (TabSpecificContentSettings::MICROPHONE_ACCESSED |
-                   TabSpecificContentSettings::CAMERA_ACCESSED));
+  DCHECK(CameraAccessed() || MicrophoneAccessed());
 
   SetTitle();
   SetRadioGroup();
   SetMediaMenus();
+  SetManageLink();
   SetCustomLink();
 }
 
 ContentSettingMediaStreamBubbleModel::~ContentSettingMediaStreamBubbleModel() {
   // On some platforms (e.g. MacOS X) it is possible to close a tab while the
   // media stream bubble is open. This resets the web contents to NULL.
   if (!web_contents())
     return;
 
   for (const std::pair<content::MediaStreamType, MediaMenu>& media_menu :
        bubble_content().media_menus) {
     if (media_menu.second.selected_device.id !=
         media_menu.second.default_device.id) {
       UpdateDefaultDeviceForType(media_menu.first,
                                  media_menu.second.selected_device.id);
     }
   }
 
   // Update the media settings if the radio button selection was changed.
   if (selected_item_ != bubble_content().radio_group.default_item) {
     UpdateSettings(radio_item_setting_[selected_item_]);
   }
 }
 
+bool ContentSettingMediaStreamBubbleModel::MicrophoneAccessed() const {
+  return (state_ & TabSpecificContentSettings::MICROPHONE_ACCESSED) != 0;
+}
+
+bool ContentSettingMediaStreamBubbleModel::CameraAccessed() const {
+  return (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) != 0;
+}
+
+void ContentSettingMediaStreamBubbleModel::OnManageLinkClicked() {
+  if (!delegate())
+    return;
+
+  if (MicrophoneAccessed()) {
+    delegate()->ShowContentSettingsPage(CameraAccessed()
+        ? CONTENT_SETTINGS_TYPE_MEDIASTREAM
+        : CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC);
+  } else {
+    delegate()->ShowContentSettingsPage(
+        CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA);
+  }
+}
+
 void ContentSettingMediaStreamBubbleModel::SetTitle() {
-  DCHECK_NE(TabSpecificContentSettings::MICROPHONE_CAMERA_NOT_ACCESSED, state_);
+  DCHECK(CameraAccessed() || MicrophoneAccessed());
   int title_id = 0;
   if (state_ & TabSpecificContentSettings::MICROPHONE_BLOCKED) {
     title_id = (state_ & TabSpecificContentSettings::CAMERA_BLOCKED) ?
         IDS_MICROPHONE_CAMERA_BLOCKED : IDS_MICROPHONE_BLOCKED;
   } else if (state_ & TabSpecificContentSettings::CAMERA_BLOCKED) {
     title_id = IDS_CAMERA_BLOCKED;
-  } else if (state_ & TabSpecificContentSettings::MICROPHONE_ACCESSED) {
-    title_id = (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) ?
-        IDS_MICROPHONE_CAMERA_ALLOWED : IDS_MICROPHONE_ACCESSED;
-  } else if (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) {
+  } else if (MicrophoneAccessed()) {
+    title_id = CameraAccessed() ? IDS_MICROPHONE_CAMERA_ALLOWED
+                                : IDS_MICROPHONE_ACCESSED;
+  } else if (CameraAccessed()) {
     title_id = IDS_CAMERA_ACCESSED;
   }
   set_title(l10n_util::GetStringUTF8(title_id));
 }
 
 void ContentSettingMediaStreamBubbleModel::SetRadioGroup() {
   TabSpecificContentSettings* content_settings =
       TabSpecificContentSettings::FromWebContents(web_contents());
   GURL url = content_settings->media_stream_access_origin();
   RadioGroup radio_group;
   radio_group.url = url;
 
   base::string16 display_host_utf16 =
       secure_display::FormatUrlForSecurityDisplay(
           url, profile()->GetPrefs()->GetString(prefs::kAcceptLanguages));
   std::string display_host(base::UTF16ToUTF8(display_host_utf16));
   if (display_host.empty())
     display_host = url.spec();
 
-  bool is_mic = (state_ & TabSpecificContentSettings::MICROPHONE_ACCESSED) != 0;
-  bool is_cam = (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) != 0;
-  DCHECK(is_mic || is_cam);
+  DCHECK(CameraAccessed() || MicrophoneAccessed());
   int radio_allow_label_id = 0;
   int radio_block_label_id = 0;
   if (state_ & (TabSpecificContentSettings::MICROPHONE_BLOCKED |
                 TabSpecificContentSettings::CAMERA_BLOCKED)) {
     if (content::IsOriginSecure(url)) {
       radio_item_setting_[0] = CONTENT_SETTING_ALLOW;
       radio_allow_label_id = IDS_BLOCKED_MEDIASTREAM_CAMERA_ALLOW;
-      if (is_mic)
-        radio_allow_label_id = is_cam ?
+      if (MicrophoneAccessed())
+        radio_allow_label_id = CameraAccessed() ?
             IDS_BLOCKED_MEDIASTREAM_MIC_AND_CAMERA_ALLOW :
             IDS_BLOCKED_MEDIASTREAM_MIC_ALLOW;
     } else {
       radio_allow_label_id = IDS_BLOCKED_MEDIASTREAM_CAMERA_ASK;
-      if (is_mic)
-        radio_allow_label_id = is_cam ?
+      if (MicrophoneAccessed())
+        radio_allow_label_id = CameraAccessed() ?
             IDS_BLOCKED_MEDIASTREAM_MIC_AND_CAMERA_ASK :
             IDS_BLOCKED_MEDIASTREAM_MIC_ASK;
     }
     radio_block_label_id = IDS_BLOCKED_MEDIASTREAM_CAMERA_NO_ACTION;
-    if (is_mic)
-      radio_block_label_id = is_cam ?
+    if (MicrophoneAccessed())
+      radio_block_label_id = CameraAccessed() ?
           IDS_BLOCKED_MEDIASTREAM_MIC_AND_CAMERA_NO_ACTION :
           IDS_BLOCKED_MEDIASTREAM_MIC_NO_ACTION;
   } else {
-    if (is_mic && is_cam) {
+    if (MicrophoneAccessed() && CameraAccessed()) {
       radio_allow_label_id = IDS_ALLOWED_MEDIASTREAM_MIC_AND_CAMERA_NO_ACTION;
       radio_block_label_id = IDS_ALLOWED_MEDIASTREAM_MIC_AND_CAMERA_BLOCK;
-    } else if (is_mic) {
+    } else if (MicrophoneAccessed()) {
       radio_allow_label_id = IDS_ALLOWED_MEDIASTREAM_MIC_NO_ACTION;
       radio_block_label_id = IDS_ALLOWED_MEDIASTREAM_MIC_BLOCK;
     } else {
       radio_allow_label_id = IDS_ALLOWED_MEDIASTREAM_CAMERA_NO_ACTION;
       radio_block_label_id = IDS_ALLOWED_MEDIASTREAM_CAMERA_BLOCK;
     }
   }
   selected_item_ =
-      (is_mic && content_settings->IsContentBlocked(
+      (MicrophoneAccessed() && content_settings->IsContentBlocked(
           CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC)) ||
-      (is_cam && content_settings->IsContentBlocked(
+      (CameraAccessed() && content_settings->IsContentBlocked(
           CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA)) ? 1 : 0;
 
   std::string radio_allow_label = l10n_util::GetStringFUTF8(
       radio_allow_label_id, base::UTF8ToUTF16(display_host));
   std::string radio_block_label =
       l10n_util::GetStringUTF8(radio_block_label_id);
 
   radio_group.default_item = selected_item_;
   radio_group.radio_items.push_back(radio_allow_label);
   radio_group.radio_items.push_back(radio_block_label);
@@ skipping 11 matching lines @@
         TabSpecificContentSettings::FromWebContents(web_contents());
     // The same patterns must be used as in other places (e.g. the infobar) in
     // order to override the existing rule. Otherwise a new rule is created.
     // TODO(markusheintz): Extract to a helper so that there is only a single
     // place to touch.
     ContentSettingsPattern primary_pattern =
         ContentSettingsPattern::FromURLNoWildcard(
             tab_content_settings->media_stream_access_origin());
     ContentSettingsPattern secondary_pattern =
         ContentSettingsPattern::Wildcard();
-    if (state_ & TabSpecificContentSettings::MICROPHONE_ACCESSED) {
+    if (MicrophoneAccessed()) {
       content_settings->SetContentSetting(
           primary_pattern, secondary_pattern,
           CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, std::string(), setting);
     }
-    if (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) {
+    if (CameraAccessed()) {
       content_settings->SetContentSetting(
           primary_pattern, secondary_pattern,
           CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, std::string(), setting);
     }
   }
 }
 
 void ContentSettingMediaStreamBubbleModel::UpdateDefaultDeviceForType(
     content::MediaStreamType type,
     const std::string& device) {
@@ skipping 14 matching lines @@
   const std::string& requested_camera =
       content_settings->media_stream_requested_video_device();
 
   // Add microphone menu.
   PrefService* prefs = profile()->GetPrefs();
   MediaCaptureDevicesDispatcher* dispatcher =
       MediaCaptureDevicesDispatcher::GetInstance();
   const content::MediaStreamDevices& microphones =
       dispatcher->GetAudioCaptureDevices();
 
-  if (state_ & TabSpecificContentSettings::MICROPHONE_ACCESSED) {
+  if (MicrophoneAccessed()) {
     MediaMenu mic_menu;
     mic_menu.label = l10n_util::GetStringUTF8(IDS_MEDIA_SELECTED_MIC_LABEL);
     if (!microphones.empty()) {
       std::string preferred_mic;
       if (requested_microphone.empty()) {
         preferred_mic = prefs->GetString(prefs::kDefaultAudioCaptureDevice);
         mic_menu.disabled = false;
       } else {
         // Set the |disabled| to true in order to disable the device selection
         // menu on the media settings bubble. This must be done if the website
         // manages the microphone devices itself.
         preferred_mic = requested_microphone;
         mic_menu.disabled = true;
       }
 
       mic_menu.default_device = GetMediaDeviceById(preferred_mic, microphones);
       mic_menu.selected_device = mic_menu.default_device;
     }
     add_media_menu(content::MEDIA_DEVICE_AUDIO_CAPTURE, mic_menu);
   }
 
-  if (state_ & TabSpecificContentSettings::CAMERA_ACCESSED) {
+  if (CameraAccessed()) {
     const content::MediaStreamDevices& cameras =
         dispatcher->GetVideoCaptureDevices();
     MediaMenu camera_menu;
     camera_menu.label =
         l10n_util::GetStringUTF8(IDS_MEDIA_SELECTED_CAMERA_LABEL);
     if (!cameras.empty()) {
       std::string preferred_camera;
       if (requested_camera.empty()) {
         preferred_camera = prefs->GetString(prefs::kDefaultVideoCaptureDevice);
         camera_menu.disabled = false;
       } else {
         // Disable the menu since the website is managing the camera devices
         // itself.
         preferred_camera = requested_camera;
         camera_menu.disabled = true;
       }
 
       camera_menu.default_device =
           GetMediaDeviceById(preferred_camera, cameras);
       camera_menu.selected_device = camera_menu.default_device;
     }
     add_media_menu(content::MEDIA_DEVICE_VIDEO_CAPTURE, camera_menu);
   }
 }
 
+void ContentSettingMediaStreamBubbleModel::SetManageLink() {
+  // By default, the manage link refers to both media types. We only need
+  // to change the link text if only one media type was accessed.
+  if (CameraAccessed() && MicrophoneAccessed())
+    return;
+
+  set_manage_link(l10n_util::GetStringUTF8(MicrophoneAccessed()
+      ? IDS_MEDIASTREAM_MICROPHONE_BUBBLE_MANAGE_LINK
+      : IDS_MEDIASTREAM_CAMERA_BUBBLE_MANAGE_LINK));
+}
+
 void ContentSettingMediaStreamBubbleModel::SetCustomLink() {
   TabSpecificContentSettings* content_settings =
       TabSpecificContentSettings::FromWebContents(web_contents());
   if (content_settings->IsMicrophoneCameraStateChanged()) {
     set_custom_link(l10n_util::GetStringUTF8(
         IDS_MEDIASTREAM_SETTING_CHANGED_MESSAGE));
   }
 }
 
 void ContentSettingMediaStreamBubbleModel::OnRadioClicked(int radio_index) {
@@ skipping 441 matching lines @@
   if (type == content::NOTIFICATION_WEB_CONTENTS_DESTROYED) {
     DCHECK_EQ(web_contents_,
               content::Source<WebContents>(source).ptr());
     web_contents_ = NULL;
   } else {
     DCHECK_EQ(chrome::NOTIFICATION_PROFILE_DESTROYED, type);
     DCHECK_EQ(profile_, content::Source<Profile>(source).ptr());
     profile_ = NULL;
   }
 }