Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: build/landmines.py

Issue 12665006: Set Android Clobber landmine (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file holds a list of reasons why a particular build needs to be clobbered 7 This file holds a list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 9
10 This script runs every build as a hook. If it detects that the build should 10 This script runs every build as a hook. If it detects that the build should
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 target is 'Release' or 'Debug' 134 target is 'Release' or 'Debug'
135 """ 135 """
136 landmines = [] 136 landmines = []
137 add = lambda item: landmines.append(item + '\n') 137 add = lambda item: landmines.append(item + '\n')
138 138
139 if (distributor() == 'goma' and platform() == 'win32' and 139 if (distributor() == 'goma' and platform() == 'win32' and
140 builder() == 'ninja'): 140 builder() == 'ninja'):
141 add('Need to clobber winja goma due to backend cwd cache fix.') 141 add('Need to clobber winja goma due to backend cwd cache fix.')
142 if platform() == 'android': 142 if platform() == 'android':
143 add('Fix findbugs errors on android trybots.') 143 add('Fix findbugs errors on android trybots.')
144 add('Clobber: jar location moved in crrev.com/183639')
144 if platform() == 'win' and builder() == 'ninja': 145 if platform() == 'win' and builder() == 'ninja':
145 add('Compile on cc_unittests fails due to symbols removed in r185063.') 146 add('Compile on cc_unittests fails due to symbols removed in r185063.')
146 if platform() == 'linux' and builder() == 'ninja': 147 if platform() == 'linux' and builder() == 'ninja':
147 add('Builders switching from make to ninja will clobber on this.') 148 add('Builders switching from make to ninja will clobber on this.')
148 149
149 return landmines 150 return landmines
150 151
151 152
152 def get_target_build_dir(build_tool, target, is_iphone=False): 153 def get_target_build_dir(build_tool, target, is_iphone=False):
153 """ 154 """
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 gyp_helper.apply_chromium_gyp_env() 225 gyp_helper.apply_chromium_gyp_env()
225 226
226 for target in ('Debug', 'Release'): 227 for target in ('Debug', 'Release'):
227 set_up_landmines(target) 228 set_up_landmines(target)
228 229
229 return 0 230 return 0
230 231
231 232
232 if __name__ == '__main__': 233 if __name__ == '__main__':
233 sys.exit(main()) 234 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698