cc: Use highp precision for texture coords if available and needed

cc/output/gl_renderer.h

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_GL_RENDERER_H_
 #define CC_OUTPUT_GL_RENDERER_H_
 
 #include "cc/base/cc_export.h"
 #include "cc/output/direct_renderer.h"
 #include "cc/output/gl_renderer_draw_cache.h"
@@ skipping 211 matching lines @@
   // Render surface shaders.
   typedef ProgramBinding<VertexShaderPosTexTransform,
                          FragmentShaderRGBATexAlpha> RenderPassProgram;
   typedef ProgramBinding<VertexShaderPosTexTransform,
                          FragmentShaderRGBATexAlphaMask> RenderPassMaskProgram;
   typedef ProgramBinding<VertexShaderQuad, FragmentShaderRGBATexAlphaAA>
       RenderPassProgramAA;
   typedef ProgramBinding<VertexShaderQuad, FragmentShaderRGBATexAlphaMaskAA>
       RenderPassMaskProgramAA;
 
+  typedef ProgramBinding<VertexShaderPosTexTransform,

[vangelis, 2013/03/20 19:20:44]

I don't believe the highp typedefs are needed. They are identical to the normalp
and they're not used anyway.

[brianderson, 2013/03/20 20:57:15]

Ah yes, these are not needed and are not used. I used to have the precision as a
template parameter, but decided not to take that route.

+                         FragmentShaderRGBATexAlpha> RenderPassProgramHighP;
+  typedef ProgramBinding<VertexShaderPosTexTransform,
+                         FragmentShaderRGBATexAlphaMask> RenderPassMaskProgramHighP;
+  typedef ProgramBinding<VertexShaderQuad, FragmentShaderRGBATexAlphaAA>
+      RenderPassProgramAAHighP;
+  typedef ProgramBinding<VertexShaderQuad, FragmentShaderRGBATexAlphaMaskAA>
+      RenderPassMaskProgramAAHighP;
+
   // Texture shaders.
   typedef ProgramBinding<VertexShaderPosTexTransform,
                          FragmentShaderRGBATexVaryingAlpha> TextureProgram;
   typedef ProgramBinding<VertexShaderPosTexTransformFlip,
                          FragmentShaderRGBATexVaryingAlpha> TextureProgramFlip;
   typedef ProgramBinding<VertexShaderPosTexTransform,
                          FragmentShaderRGBATexRectVaryingAlpha>
       TextureIOSurfaceProgram;
 
+  typedef ProgramBinding<VertexShaderPosTexTransform,
+                         FragmentShaderRGBATexVaryingAlpha> TextureProgramHighP;
+  typedef ProgramBinding<VertexShaderPosTexTransformFlip,
+                         FragmentShaderRGBATexVaryingAlpha> TextureProgramFlipHighP;
+  typedef ProgramBinding<VertexShaderPosTexTransform,
+                         FragmentShaderRGBATexRectVaryingAlpha>
+      TextureIOSurfaceProgramHighP;
+
   // Video shaders.
   typedef ProgramBinding<VertexShaderVideoTransform,
                          FragmentShaderOESImageExternal>
       VideoStreamTextureProgram;
   typedef ProgramBinding<VertexShaderPosTexYUVStretch, FragmentShaderYUVVideo>
       VideoYUVProgram;
 
+  typedef ProgramBinding<VertexShaderVideoTransform,
+                         FragmentShaderOESImageExternal>
+      VideoStreamTextureProgramHighP;
+  typedef ProgramBinding<VertexShaderPosTexYUVStretch, FragmentShaderYUVVideo>
+      VideoYUVProgramHighP;
+
   // Special purpose / effects shaders.
   typedef ProgramBinding<VertexShaderPos, FragmentShaderColor>
       DebugBorderProgram;
   typedef ProgramBinding<VertexShaderQuad, FragmentShaderColor>
       SolidColorProgram;
   typedef ProgramBinding<VertexShaderQuad, FragmentShaderColorAA>
       SolidColorProgramAA;
 
   const TileProgram* GetTileProgram();
   const TileProgramOpaque* GetTileProgramOpaque();
   const TileProgramAA* GetTileProgramAA();
   const TileProgramSwizzle* GetTileProgramSwizzle();
   const TileProgramSwizzleOpaque* GetTileProgramSwizzleOpaque();
   const TileProgramSwizzleAA* GetTileProgramSwizzleAA();
   const TileCheckerboardProgram* GetTileCheckerboardProgram();
 
-  const RenderPassProgram* GetRenderPassProgram();
-  const RenderPassProgramAA* GetRenderPassProgramAA();
-  const RenderPassMaskProgram* GetRenderPassMaskProgram();
-  const RenderPassMaskProgramAA* GetRenderPassMaskProgramAA();
+  const RenderPassProgram* GetRenderPassProgram(
+      TexCoordPrecision precision);
+  const RenderPassProgramAA* GetRenderPassProgramAA(
+      TexCoordPrecision precision);
+  const RenderPassMaskProgram* GetRenderPassMaskProgram(
+      TexCoordPrecision precision);
+  const RenderPassMaskProgramAA* GetRenderPassMaskProgramAA(
+      TexCoordPrecision precision);
 
-  const TextureProgram* GetTextureProgram();
-  const TextureProgramFlip* GetTextureProgramFlip();
-  const TextureIOSurfaceProgram* GetTextureIOSurfaceProgram();
+  const TextureProgram* GetTextureProgram(
+      TexCoordPrecision precision);
+  const TextureProgramFlip* GetTextureProgramFlip(
+      TexCoordPrecision precision);
+  const TextureIOSurfaceProgram* GetTextureIOSurfaceProgram(
+      TexCoordPrecision precision);
 
-  const VideoYUVProgram* GetVideoYUVProgram();
-  const VideoStreamTextureProgram* GetVideoStreamTextureProgram();
+  const VideoYUVProgram* GetVideoYUVProgram(
+      TexCoordPrecision precision);
+  const VideoStreamTextureProgram* GetVideoStreamTextureProgram(
+      TexCoordPrecision precision);
 
   const DebugBorderProgram* GetDebugBorderProgram();
   const SolidColorProgram* GetSolidColorProgram();
   const SolidColorProgramAA* GetSolidColorProgramAA();
 
   scoped_ptr<TileProgram> tile_program_;
   scoped_ptr<TileProgramOpaque> tile_program_opaque_;
   scoped_ptr<TileProgramAA> tile_program_aa_;
   scoped_ptr<TileProgramSwizzle> tile_program_swizzle_;
   scoped_ptr<TileProgramSwizzleOpaque> tile_program_swizzle_opaque_;
   scoped_ptr<TileProgramSwizzleAA> tile_program_swizzle_aa_;
   scoped_ptr<TileCheckerboardProgram> tile_checkerboard_program_;
 
   scoped_ptr<RenderPassProgram> render_pass_program_;
   scoped_ptr<RenderPassProgramAA> render_pass_program_aa_;
   scoped_ptr<RenderPassMaskProgram> render_pass_mask_program_;
   scoped_ptr<RenderPassMaskProgramAA> render_pass_mask_program_aa_;
 
+  scoped_ptr<RenderPassProgram> render_pass_program_highp_;
+  scoped_ptr<RenderPassProgramAA> render_pass_program_aa_highp_;
+  scoped_ptr<RenderPassMaskProgram> render_pass_mask_program_highp_;
+  scoped_ptr<RenderPassMaskProgramAA> render_pass_mask_program_aa_highp_;
+
   scoped_ptr<TextureProgram> texture_program_;
   scoped_ptr<TextureProgramFlip> texture_program_flip_;
   scoped_ptr<TextureIOSurfaceProgram> texture_io_surface_program_;
 
+  scoped_ptr<TextureProgram> texture_program_highp_;
+  scoped_ptr<TextureProgramFlip> texture_program_flip_highp_;
+  scoped_ptr<TextureIOSurfaceProgram> texture_io_surface_program_highp_;
+
   scoped_ptr<VideoYUVProgram> video_yuv_program_;
   scoped_ptr<VideoStreamTextureProgram> video_stream_texture_program_;
 
+  scoped_ptr<VideoYUVProgram> video_yuv_program_highp_;
+  scoped_ptr<VideoStreamTextureProgram> video_stream_texture_program_highp_;
+
   scoped_ptr<DebugBorderProgram> debug_border_program_;
   scoped_ptr<SolidColorProgram> solid_color_program_;
   scoped_ptr<SolidColorProgramAA> solid_color_program_aa_;
 
   OutputSurface* output_surface_;
   WebKit::WebGraphicsContext3D* context_;
 
   gfx::Rect swap_buffer_rect_;
   gfx::Rect scissor_rect_;
   bool is_viewport_changed_;
@@ skipping 21 matching lines @@
 #if DEBUG_GL_CALLS && !defined(NDEBUG)
 #define GLC(context, x)                                                        \
   (x, GLRenderer::DebugGLCall (&* context, #x, __FILE__, __LINE__))
 #else
 #define GLC(context, x) (x)
 #endif
 
 }
 
 #endif  // CC_OUTPUT_GL_RENDERER_H_