content/renderer/password_form_conversion_utils.cc - Issue 12665003: Convert invalid WebPasswordFormData to null (rather than empty) PasswordForm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/password_form_conversion_utils.cc

Issue 12665003: Convert invalid WebPasswordFormData to null (rather than empty) PasswordForm. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Added test Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_tests.gypi ('k') | content/renderer/password_form_conversion_utils_browsertest.cc » ('j') | content/renderer/password_form_conversion_utils_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/password_form_conversion_utils.cc

diff --git a/content/renderer/password_form_conversion_utils.cc b/content/renderer/password_form_conversion_utils.cc

index e38d1ddf511afbdc0c9fe09cadb8ff4d65b27e7d..68b1ee5bc01bacd7d9ba87a2d09406b8da2035b7 100644

--- a/content/renderer/password_form_conversion_utils.cc

+++ b/content/renderer/password_form_conversion_utils.cc

@@ -42,7 +42,7 @@ scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) {

WebPasswordFormData web_password_form(webform);

if (web_password_form.isValid())

return InitPasswordFormFromWebPasswordForm(web_password_form);

- return scoped_ptr<PasswordForm>(new PasswordForm());

+ return scoped_ptr<PasswordForm>();

}

} // namespace content