Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266483003: format with dart_style 0.2.0-rc.3 (Closed)

Created:
5 years, 4 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

format with dart_style 0.2.0-rc.3 this unblocks null aware ops R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/3bdc10c3eb99c6cc40b552f0da5a4c60fce6d76b

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -347 lines) Patch
M bin/edit_files.dart View 3 chunks +15 lines, -8 lines 0 comments Download
M lib/runtime/messages_widget.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/analysis_context.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/codegen/ast_builder.dart View 4 chunks +18 lines, -9 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 33 chunks +102 lines, -122 lines 0 comments Download
M lib/src/codegen/js_metalet.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M lib/src/codegen/js_module_item_order.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/codegen/js_names.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/codegen/reify_coercions.dart View 3 chunks +3 lines, -1 line 0 comments Download
M lib/src/codegen/side_effect_analysis.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
M lib/src/info.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/options.dart View 8 chunks +39 lines, -21 lines 0 comments Download
M lib/src/server/dependency_graph.dart View 1 2 chunks +30 lines, -24 lines 0 comments Download
M lib/src/server/server.dart View 1 2 chunks +21 lines, -20 lines 0 comments Download
M lib/src/summary.dart View 6 chunks +29 lines, -27 lines 0 comments Download
M lib/strong_mode.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/checker/checker_test.dart View 10 chunks +40 lines, -23 lines 0 comments Download
M test/checker/inferred_type_test.dart View 3 chunks +13 lines, -5 lines 0 comments Download
M test/checker/self_host_test.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M test/codegen_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M test/dependency_graph_test.dart View 35 chunks +112 lines, -39 lines 0 comments Download
M test/report_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/testing.dart View 4 chunks +21 lines, -17 lines 0 comments Download
M tool/patch_sdk.dart View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
Note, we'll be able to revert some of the odd formatting once this bug is ...
5 years, 4 months ago (2015-07-29 00:23:04 UTC) #3
vsm
lgtm
5 years, 4 months ago (2015-07-29 01:18:15 UTC) #4
Jennifer Messerly
5 years, 4 months ago (2015-07-29 01:19:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
3bdc10c3eb99c6cc40b552f0da5a4c60fce6d76b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698