Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1266463002: Save vector icons in a cache (a la ResourceBundle). (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Save vector icons in a cache (a la ResourceBundle). This means we only have to actually draw one time (per image/color/size) and the bytes will be stored thereafter. The drawing is the most expensive part so this should be a performance optimization. This also means we will share memory between two places that use the same icon. However, this also means that memory is never freed. One other motivation for this change is that parts of Chrome's codebase (in particular favicons) deal in raw pointers to png data, which it assumes will last indefinitely. BUG=505953 Committed: https://crrev.com/2ee31b326a16ab5bb18a89432a5e1c9a06363da3 Cr-Commit-Position: refs/heads/master@{#340902}

Patch Set 1 #

Patch Set 2 : no base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M ui/gfx/paint_vector_icon.cc View 3 chunks +51 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
5 years, 4 months ago (2015-07-28 22:34:52 UTC) #3
Evan Stade
5 years, 4 months ago (2015-07-28 22:34:52 UTC) #4
sky
LGTM
5 years, 4 months ago (2015-07-28 23:55:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266463002/20001
5 years, 4 months ago (2015-07-29 16:17:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 16:50:01 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 16:51:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ee31b326a16ab5bb18a89432a5e1c9a06363da3
Cr-Commit-Position: refs/heads/master@{#340902}

Powered by Google App Engine
This is Rietveld 408576698