Chromium Code Reviews
DescriptionSave vector icons in a cache (a la ResourceBundle).
This means we only have to actually draw one time (per image/color/size)
and the bytes will be stored thereafter. The drawing is the most expensive
part so this should be a performance optimization. This also means we will
share memory between two places that use the same icon. However, this also
means that memory is never freed.
One other motivation for this change is that parts of Chrome's codebase
(in particular favicons) deal in raw pointers to png data, which it assumes
will last indefinitely.
BUG=505953
Committed: https://crrev.com/2ee31b326a16ab5bb18a89432a5e1c9a06363da3
Cr-Commit-Position: refs/heads/master@{#340902}
Patch Set 1 #Patch Set 2 : no base #
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||