Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 12664009: Revert 189134 "Due to privacy concerns about the data contained ..." (Closed)

Created:
7 years, 9 months ago by felt
Modified:
7 years, 9 months ago
Reviewers:
felt
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 189134 "Due to privacy concerns about the data contained ..." > Due to privacy concerns about the data contained in API call arguments, we no longer will log the arguments unless: > > (1) The API call has been whitelisted because we need the arguments and there is no explicit privacy issue w/r/t the arguments of that API call, or > > (2) The browser's activity log testing flag has been set. > > I set up an API_action whitelist with a few preliminary ones. We'll probably need to expand it and add similar whitelists for events. > > For now, this does not affect DOM API calls because we will be taking a whitelisting approach to DOM API calls to begin with. > > Review URL: https://chromiumcodereview.appspot.com/12918020 TBR=felt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -114 lines) Patch
MM trunk/src/chrome/browser/extensions/activity_log.h View 2 chunks +0 lines, -8 lines 0 comments Download
MM trunk/src/chrome/browser/extensions/activity_log.cc View 4 chunks +4 lines, -26 lines 0 comments Download
M trunk/src/chrome/browser/extensions/activity_log_unittest.cc View 2 chunks +0 lines, -67 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api_actions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api_actions.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
felt
7 years, 9 months ago (2013-03-19 23:38:48 UTC) #1
felt
7 years, 9 months ago (2013-03-19 23:38:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r189154.

Powered by Google App Engine
This is Rietveld 408576698