Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: pkg/analysis_server/test/edit/sort_members_test.dart

Issue 1266393002: Organize directives implementation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: renames Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/sort_members_test.dart
diff --git a/pkg/analysis_server/test/edit/sort_members_test.dart b/pkg/analysis_server/test/edit/sort_members_test.dart
index 6aa638c72137dc8adbfba8b0e78bc8e5a97189e5..194baa9efa95dba78d00bae65a226238893f9d9d 100644
--- a/pkg/analysis_server/test/edit/sort_members_test.dart
+++ b/pkg/analysis_server/test/edit/sort_members_test.dart
@@ -33,38 +33,35 @@ class SortMembersTest extends AbstractAnalysisTest {
handler = new EditDomainHandler(server);
}
- Future test_BAD_doesNotExist() {
- return waitForTasksFinished().then((_) {
- Request request =
- new EditSortMembersParams('/no/such/file.dart').toRequest('0');
- Response response = handler.handleRequest(request);
- expect(response,
- isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_INVALID_FILE));
- });
+ Future test_BAD_doesNotExist() async {
+ await waitForTasksFinished();
+ Request request =
+ new EditSortMembersParams('/no/such/file.dart').toRequest('0');
+ Response response = handler.handleRequest(request);
+ expect(response,
+ isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_INVALID_FILE));
}
- Future test_BAD_hasParseError() {
+ Future test_BAD_hasParseError() async {
addTestFile('''
main() {
print()
}
''');
- return waitForTasksFinished().then((_) {
- Request request = new EditSortMembersParams(testFile).toRequest('0');
- Response response = handler.handleRequest(request);
- expect(response,
- isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_PARSE_ERRORS));
- });
+ await waitForTasksFinished();
+ Request request = new EditSortMembersParams(testFile).toRequest('0');
+ Response response = handler.handleRequest(request);
+ expect(response,
+ isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_PARSE_ERRORS));
}
- Future test_BAD_notDartFile() {
- return waitForTasksFinished().then((_) {
- Request request =
- new EditSortMembersParams('/not-a-Dart-file.txt').toRequest('0');
- Response response = handler.handleRequest(request);
- expect(response,
- isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_INVALID_FILE));
- });
+ Future test_BAD_notDartFile() async {
+ await waitForTasksFinished();
+ Request request =
+ new EditSortMembersParams('/not-a-Dart-file.txt').toRequest('0');
+ Response response = handler.handleRequest(request);
+ expect(response,
+ isResponseFailure('0', RequestErrorCode.SORT_MEMBERS_INVALID_FILE));
}
Future test_OK_classMembers_method() {
@@ -148,12 +145,11 @@ class C {}
''');
}
- Future _assertSorted(String expectedCode) {
- return waitForTasksFinished().then((_) {
- _requestSort();
- String resultCode = SourceEdit.applySequence(testCode, fileEdit.edits);
- expect(resultCode, expectedCode);
- });
+ Future _assertSorted(String expectedCode) async {
+ await waitForTasksFinished();
+ _requestSort();
+ String resultCode = SourceEdit.applySequence(testCode, fileEdit.edits);
+ expect(resultCode, expectedCode);
}
void _requestSort() {

Powered by Google App Engine
This is Rietveld 408576698