Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1266373002: Fix link typo in gn cookbook doc. (Closed)

Created:
5 years, 4 months ago by Bons
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix link typo in gn cookbook doc. BUG=none Committed: https://crrev.com/5087842b0c12776ce31876754346dc65c2382037 Cr-Commit-Position: refs/heads/master@{#341587}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix links #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M tools/gn/docs/cookbook.md View 1 19 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266373002/1
5 years, 4 months ago (2015-08-03 19:05:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-03 19:05:43 UTC) #5
Dirk Pranke
https://codereview.chromium.org/1266373002/diff/1/tools/gn/docs/cookbook.md File tools/gn/docs/cookbook.md (left): https://codereview.chromium.org/1266373002/diff/1/tools/gn/docs/cookbook.md#oldcode30 tools/gn/docs/cookbook.md:30: stripped out] if it's not called from within the ...
5 years, 4 months ago (2015-08-03 19:18:09 UTC) #6
Bons
https://codereview.chromium.org/1266373002/diff/1/tools/gn/docs/cookbook.md File tools/gn/docs/cookbook.md (left): https://codereview.chromium.org/1266373002/diff/1/tools/gn/docs/cookbook.md#oldcode30 tools/gn/docs/cookbook.md:30: stripped out] if it's not called from within the ...
5 years, 4 months ago (2015-08-03 19:23:00 UTC) #7
Dirk Pranke
lgtm, thanks!
5 years, 4 months ago (2015-08-03 19:26:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266373002/20001
5 years, 4 months ago (2015-08-03 19:27:30 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 19:36:35 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 19:37:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5087842b0c12776ce31876754346dc65c2382037
Cr-Commit-Position: refs/heads/master@{#341587}

Powered by Google App Engine
This is Rietveld 408576698