Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 126633004: Update DOM classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, chromiumbugtracker_adobe.com, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Update DOM classes to use OVERRIDE / FINAL when needed Update DOM classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -106 lines) Patch
M Source/core/dom/Attr.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/CDATASection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Comment.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMSettableTokenList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DatasetDOMStringMap.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/dom/DecodedDataDocumentParser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Document.h View 10 chunks +32 lines, -32 lines 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarker.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ExecutionContextTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NamedFlowCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/RawDataDocumentParser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptableDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/TagNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/WheelController.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-08 02:04:58 UTC) #1
esprehn
Nice! lgtm
6 years, 11 months ago (2014-01-08 02:08:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/126633004/1
6 years, 11 months ago (2014-01-08 02:11:10 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 09:58:12 UTC) #4
Message was sent while issue was closed. 
Change committed as 164668

Powered by Google App Engine
This is Rietveld 408576698