Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: pkg/scheduled_test/test/scheduled_process_test.dart

Issue 12663006: Fix the build breakages caused by r19742. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/test/scheduled_process_test.dart
diff --git a/pkg/scheduled_test/test/scheduled_process_test.dart b/pkg/scheduled_test/test/scheduled_process_test.dart
index a2010889ee56a4819bcfa7b06f88c07b5ab0a503..02a113c2cd5cd3067d2cf99c24e961f5a6498ecc 100644
--- a/pkg/scheduled_test/test/scheduled_process_test.dart
+++ b/pkg/scheduled_test/test/scheduled_process_test.dart
@@ -31,8 +31,8 @@ void main() {
expect(errors.length, equals(1));
expect(errors.first.error, isStateError);
expect(errors.first.error.message, matches(r"^Scheduled process "
- r"'[^']+[\\/]dart' must have shouldExit\(\) or kill\(\) called "
- r"before the test is run\.$"));
+ r"'[^']+[\\/]dart(\.exe)?' must have shouldExit\(\) or kill\(\) "
+ r"called before the test is run\.$"));
});
}, passing: ['test 2']);
@@ -118,29 +118,31 @@ void main() {
});
});
- expectTestsPass("a process that ends while waiting for stdout shouldn't "
- "block the test", () {
- var errors;
- test('test 1', () {
- currentSchedule.onException.schedule(() {
- errors = currentSchedule.errors;
- });
-
- var process = startDartProcess('');
- expect(process.nextLine(), completion(equals('hello')));
- expect(process.nextLine(), completion(equals('world')));
- process.shouldExit(0);
- });
-
- test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.length, equals(2));
- expect(errors[0].error, isStateError);
- expect(errors[0].error.message, equals("No elements"));
- expect(errors[1].error, matches(r"^Process '[^']+[\\/]dart [^']+' ended "
- r"earlier than scheduled with exit code 0\."));
- });
- }, passing: ['test 2']);
+ // TODO(nweiz): re-enable this (issue 9022).
+ // expectTestsPass("a process that ends while waiting for stdout shouldn't "
+ // "block the test", () {
+ // var errors;
+ // test('test 1', () {
+ // currentSchedule.onException.schedule(() {
+ // errors = currentSchedule.errors;
+ // });
+ //
+ // var process = startDartProcess('');
+ // expect(process.nextLine(), completion(equals('hello')));
+ // expect(process.nextLine(), completion(equals('world')));
+ // process.shouldExit(0);
+ // });
+ //
+ // test('test 2', () {
+ // expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
+ // expect(errors.length, equals(2));
+ // expect(errors[0].error, isStateError);
+ // expect(errors[0].error.message, equals("No elements"));
+ // expect(errors[1].error, matches(r"^Process "
+ // r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+ // r"exit code 0\."));
+ // });
+ // }, passing: ['test 2']);
expectTestsPass("a process that ends during the task immediately before it's "
"scheduled to end shouldn't cause an error", () {
@@ -184,8 +186,9 @@ void main() {
expect(errors.length, equals(2));
expect(errors[0].error, isStateError);
expect(errors[0].error.message, equals("No elements"));
- expect(errors[1].error, matches(r"^Process '[^']+[\\/]dart [^']+' ended "
- r"earlier than scheduled with exit code 0\."));
+ expect(errors[1].error, matches(r"^Process "
+ r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+ r"exit code 0\."));
});
}, passing: ['test 2']);
@@ -222,8 +225,9 @@ void main() {
expect(errors.length, equals(2));
expect(errors[0].error, isStateError);
expect(errors[0].error.message, equals("No elements"));
- expect(errors[1].error, matches(r"^Process '[^']+[\\/]dart [^']+' ended "
- r"earlier than scheduled with exit code 0\."));
+ expect(errors[1].error, matches(r"^Process "
+ r"'[^']+[\\/]dart(\.exe)? [^']+' ended earlier than scheduled with "
+ r"exit code 0\."));
});
}, passing: ['test 2']);
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698