Issue 1266253002: Revert of Move strike to subrun in GrAtlasTextContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1266253002: Revert of Move strike to subrun in GrAtlasTextContext (Closed)

Created:
5 years, 4 months ago by joshualitt

Modified:
5 years, 4 months ago

Reviewers:
jvanverth1, bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Move strike to subrun in GrAtlasTextContext (patchset #3 id:40001 of https://codereview.chromium.org/1257253005/) Reason for revert: breaking bots Original issue's description: > Move strike to subrun in GrAtlasTextContext > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/77d89f7dd243a17452d3a5f16a98622993e6bdd9 TBR=bsalomon@google.com,robertphillips@google.com,jvanverth@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/da9ccf175430fd9337355334503aedb464676078

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -31 lines)			Patch
M	src/gpu/GrAtlasTextBlob.h	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	7 chunks	+7 lines, -12 lines	0 comments	Download
M	src/gpu/GrBatchAtlas.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

joshualitt

Created Revert of Move strike to subrun in GrAtlasTextContext

5 years, 4 months ago (2015-07-31 21:07:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266253002/1

5 years, 4 months ago (2015-07-31 21:07:45 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-07-31 21:07:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/da9ccf175430fd9337355334503aedb464676078

Expand Messages | Collapse Messages