chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java - Issue 1266243003: Tweaks to the precache triggering code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

Issue 1266243003: Tweaks to the precache triggering code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: PrecacheLauncherTest tweaks. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ConnectionChangeReceiver.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java » ('j') | chrome/browser/android/precache/precache_launcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

index 5f29c5f55ab5fa55b9d8576279ccd1035420a35a..be96abd1ba192757fd600fa909a34bda017ad6b5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java

@@ -169,14 +169,12 @@ public class PrivacyPreferences extends PreferenceFragment

} else if (PREF_NETWORK_PREDICTIONS.equals(key)) {

PrefServiceBridge.getInstance().setNetworkPredictionOptions(

NetworkPredictionOptions.stringToEnum((String) newValue));

- PrecacheLauncher.updatePrecachingEnabled(

- PrivacyPreferencesManager.getInstance(getActivity()), getActivity());

+ PrecacheLauncher.updatePrecachingEnabled(getActivity());

} else if (PREF_NETWORK_PREDICTIONS_NO_CELLULAR.equals(key)) {

PrefServiceBridge.getInstance().setNetworkPredictionOptions((boolean) newValue

? NetworkPredictionOptions.NETWORK_PREDICTION_ALWAYS

: NetworkPredictionOptions.NETWORK_PREDICTION_NEVER);

- PrecacheLauncher.updatePrecachingEnabled(

- PrivacyPreferencesManager.getInstance(getActivity()), getActivity());

+ PrecacheLauncher.updatePrecachingEnabled(getActivity());

} else if (PREF_NAVIGATION_ERROR.equals(key)) {

PrefServiceBridge.getInstance().setResolveNavigationErrorEnabled((boolean) newValue);

} else if (PREF_CRASH_DUMP_UPLOAD_NO_CELLULAR.equals(key)) {