Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12662019: Split the ProcessType enum into process types that content knows about (which will remain in src\co… (Closed)

Created:
7 years, 9 months ago by jam
Modified:
7 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, MAD, jar (doing other things), kkania, yoshiki+watch_chromium.org, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, robertshield, native-client-reviews_googlegroups.com, Ilya Sherman
Visibility:
Public.

Description

Split the ProcessType enum into process types that content knows about (which will remain in src\content) and those that are for chrome (which moved to src\chrome). This way we won't get any more layering violations where nacl code is in content. Also move the NaCl command line switches to chrome. BUG=191682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189763

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -213 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/memory_details.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details.cc View 11 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/memory_details_android.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory_details_mac.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/tracking_synchronizer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/tracking_synchronizer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/tracking_synchronizer_observer.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_service_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 10 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/common/chrome_process_type.h View 1 chunk +20 lines, -0 lines 2 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 chunks +17 lines, -10 lines 0 comments Download
M chrome/nacl/nacl_broker_listener.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 4 chunks +14 lines, -13 lines 2 comments Download
M content/browser/histogram_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/resource_message_filter.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/browser/loader/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/loader/resource_request_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/profiler_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/profiler_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/profiler_message_filter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/profiler_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tcmalloc_internals_request_job.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/tcmalloc_internals_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/process_type.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/public/browser/browser_child_process_host_iterator.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/public/browser/browser_child_process_host_iterator.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/public/browser/child_process_data.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/public/browser/profiler_subscriber.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/common/content_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/content_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/common/process_type.h View 1 chunk +7 lines, -5 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 9 months ago (2013-03-22 01:32:48 UTC) #1
scottmg
lgtm https://codereview.chromium.org/12662019/diff/4015/chrome/common/chrome_process_type.h File chrome/common/chrome_process_type.h (right): https://codereview.chromium.org/12662019/diff/4015/chrome/common/chrome_process_type.h#newcode12 chrome/common/chrome_process_type.h:12: // items at the end, right before MAX_PROCESS. ...
7 years, 9 months ago (2013-03-22 02:56:35 UTC) #2
jam
7 years, 9 months ago (2013-03-22 04:58:37 UTC) #3 
https://codereview.chromium.org/12662019/diff/4015/chrome/common/chrome_proce...
File chrome/common/chrome_process_type.h (right):

https://codereview.chromium.org/12662019/diff/4015/chrome/common/chrome_proce...
chrome/common/chrome_process_type.h:12: // items at the end, right before
MAX_PROCESS. We depend on these specific
On 2013/03/22 02:56:35, scottmg wrote:
> nit; comment's out of date (PROCESS_TYPE_MAX in process_type.h?). is there
> anything worth asserting here since they're in separate files?

ah, fixed comment

https://codereview.chromium.org/12662019/diff/4015/content/browser/browser_ch...
File content/browser/browser_child_process_host_impl.cc (right):

https://codereview.chromium.org/12662019/diff/4015/content/browser/browser_ch...
content/browser/browser_child_process_host_impl.cc:269:
UMA_HISTOGRAM_ENUMERATION("ChildProcess.Crashed2",
On 2013/03/22 02:56:35, scottmg wrote:
> why 2 now?

because the enum values have changed. i'll update the histograms.xml file in a
followup (since it's in a different repo)

https://codereview.chromium.org/12662019/diff/4015/content/public/common/proc...
File content/public/common/process_type.h (right):

https://codereview.chromium.org/12662019/diff/4015/content/public/common/proc...
content/public/common/process_type.h:16: // items at the end, right before
MAX_PROCESS. We depend on these specific
On 2013/03/22 02:56:35, scottmg wrote:
> process_type_max

Done.

Powered by Google App Engine
This is Rietveld 408576698