Remove OmahaClient low-end device check.

Remove OmahaClient low-end device check.

Existing users who have updated Chrome will not be forced to
change to the accessibility tab switcher. New users to update
from a chrome version before svelte mode to a version after
svelte mode was introduced will get switched to the
accessibility tab switcher.

This change saves ~45ms for every device (measured on N5 so it
should save more on slower devices). The accessibility tab
switcher is much faster and should prove to be a better
experience on low-end devices.

BUG=473352
Committed: https://crrev.com/062f5b0c1b6b331a603270fb47bc9e1017ef2b53
Cr-Commit-Position: refs/heads/master@{#341194}

[Peter Wen, 2015-07-30 19:04:13]

wnwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Peter Wen, 2015-07-30 19:04:13]

Hi Dan,

We talked about removing this check, seems Grace and Travis are okay with
removing it for the performance boost.

Since for existing users their preference is already saved in Chrome's shared
preference, they won't experience any change. Only new users will.

Thanks,

Peter

[gone, 2015-07-30 19:18:08]

lgtm

https://codereview.chromium.org/1266073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
(right):

https://codereview.chromium.org/1266073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java:181:
return mSharedPreferences.getBoolean(ALLOW_LOW_END_DEVICE_UI, true);
Man, this flip to true was confusing.  Can you change the function javadoc to
explain how it works, and why we're keeping it around?

[Peter Wen, 2015-07-30 19:42:11]

PTAL, let me know whether the comments are sufficiently clear.

https://codereview.chromium.org/1266073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
(right):

https://codereview.chromium.org/1266073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java:181:
return mSharedPreferences.getBoolean(ALLOW_LOW_END_DEVICE_UI, true);
On 2015/07/30 19:18:08, dfalcantara wrote:
> Man, this flip to true was confusing.  Can you change the function javadoc to
> explain how it works, and why we're keeping it around?

Heh, agreed. Added detailed comments, removed the set function as it was no
longer used.

[gone, 2015-07-30 20:34:19]

Yep, lgtm.  Thanks!

[Peter Wen, 2015-07-30 20:36:15]

The CQ bit was checked by wnwen@chromium.org

[commit-bot: I haz the power, 2015-07-30 20:36:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1266073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1266073002/20001

[commit-bot: I haz the power, 2015-07-30 21:28:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-30 21:29:14]

Patchset 2 (id:??) landed as
https://crrev.com/062f5b0c1b6b331a603270fb47bc9e1017ef2b53
Cr-Commit-Position: refs/heads/master@{#341194}