Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: runtime/lib/developer.cc

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/lib/developer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/bootstrap_natives.h" 5 #include "vm/bootstrap_natives.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/debugger.h" 9 #include "vm/debugger.h"
10 #include "vm/exceptions.h" 10 #include "vm/exceptions.h"
(...skipping 21 matching lines...) Expand all
32 32
33 33
34 DEFINE_NATIVE_ENTRY(Developer_inspect, 1) { 34 DEFINE_NATIVE_ENTRY(Developer_inspect, 1) {
35 GET_NATIVE_ARGUMENT(Instance, inspectee, arguments->NativeArgAt(0)); 35 GET_NATIVE_ARGUMENT(Instance, inspectee, arguments->NativeArgAt(0));
36 Service::SendInspectEvent(isolate, inspectee); 36 Service::SendInspectEvent(isolate, inspectee);
37 return inspectee.raw(); 37 return inspectee.raw();
38 } 38 }
39 39
40 40
41 DEFINE_NATIVE_ENTRY(Developer_log, 8) { 41 DEFINE_NATIVE_ENTRY(Developer_log, 8) {
42 GET_NON_NULL_NATIVE_ARGUMENT(Integer, sequence, arguments->NativeArgAt(0)); 42 GET_NON_NULL_NATIVE_ARGUMENT(String, message, arguments->NativeArgAt(0));
43 GET_NON_NULL_NATIVE_ARGUMENT(Integer, timestamp, arguments->NativeArgAt(1)); 43 GET_NON_NULL_NATIVE_ARGUMENT(Integer, timestamp, arguments->NativeArgAt(1));
44 GET_NON_NULL_NATIVE_ARGUMENT(Smi, level, arguments->NativeArgAt(2)); 44 GET_NON_NULL_NATIVE_ARGUMENT(Integer, sequence, arguments->NativeArgAt(2));
45 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(3)); 45 GET_NON_NULL_NATIVE_ARGUMENT(Smi, level, arguments->NativeArgAt(3));
46 GET_NON_NULL_NATIVE_ARGUMENT(String, message, arguments->NativeArgAt(4)); 46 GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(4));
47 GET_NATIVE_ARGUMENT(Instance, dart_zone, arguments->NativeArgAt(5)); 47 GET_NATIVE_ARGUMENT(Instance, dart_zone, arguments->NativeArgAt(5));
48 GET_NATIVE_ARGUMENT(Instance, error, arguments->NativeArgAt(6)); 48 GET_NATIVE_ARGUMENT(Instance, error, arguments->NativeArgAt(6));
49 GET_NATIVE_ARGUMENT(Instance, stack_trace, arguments->NativeArgAt(7)); 49 GET_NATIVE_ARGUMENT(Instance, stack_trace, arguments->NativeArgAt(7));
50 Service::SendLogEvent(isolate, 50 Service::SendLogEvent(isolate,
51 sequence.AsInt64Value(), 51 sequence.AsInt64Value(),
52 timestamp.AsInt64Value(), 52 timestamp.AsInt64Value(),
53 level.Value(), 53 level.Value(),
54 name, 54 name,
55 message, 55 message,
56 dart_zone, 56 dart_zone,
57 error, 57 error,
58 stack_trace); 58 stack_trace);
59 return Object::null(); 59 return Object::null();
60 } 60 }
61 61
62 } // namespace dart 62 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/lib/developer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698