Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1266053002: PPC: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. Port c5dd553cf3a44cd8c17958a5951… (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. Port c5dd553cf3a44cd8c17958a595198b5ea9492cd0 Original commit message: Adds interpreter entry and exit trampoline builtins. Also implements the Return bytecode handler and fixes a few bugs in InterpreterAssembler highlighted by running on other architectures. R=rmcilroy@chromium.org, michael_dawson@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/0ea4e6d50de8752713dbfe18588f05400796e584 Cr-Commit-Position: refs/heads/master@{#29939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -4 lines) Patch
M src/compiler/ppc/linkage-ppc.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 2 chunks +138 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-30 17:42:22 UTC) #1
john.yan
lgtm
5 years, 4 months ago (2015-07-30 18:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266053002/1
5 years, 4 months ago (2015-07-30 18:08:28 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-30 18:08:29 UTC) #6
michael_dawson
On 2015/07/30 18:08:29, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 4 months ago (2015-07-30 18:18:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266053002/1
5 years, 4 months ago (2015-07-30 18:19:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 18:43:38 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 18:43:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ea4e6d50de8752713dbfe18588f05400796e584
Cr-Commit-Position: refs/heads/master@{#29939}

Powered by Google App Engine
This is Rietveld 408576698