Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266023002: [MediaSession,Android] Use a badged notification icon for the Work profile (Closed)

Created:
5 years, 4 months ago by whywhat
Modified:
5 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaSession,Android] Use a badged notification icon for the Work profile BUG=515066 Committed: https://crrev.com/0b69a3fb58aea4a762c326f4b4ba227eead44b28 Cr-Commit-Position: refs/heads/master@{#341214}

Patch Set 1 #

Total comments: 1

Patch Set 2 : No canvas drawing into bitmap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java View 1 5 chunks +26 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1266903002 Patch 1
Issue 1270183003 Patch 1
Issue 1273753002 Patch 1

Messages

Total messages: 14 (5 generated)
whywhat
PTaL, thanks!
5 years, 4 months ago (2015-07-30 16:37:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266023002/1
5 years, 4 months ago (2015-07-30 16:37:48 UTC) #4
aurimas (slooooooooow)
https://codereview.chromium.org/1266023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java (right): https://codereview.chromium.org/1266023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java#newcode292 chrome/android/java/src/org/chromium/chrome/browser/media/ui/NotificationMediaPlaybackControls.java:292: return bitmapDrawable.getBitmap(); Almost every time we should return here. ...
5 years, 4 months ago (2015-07-30 16:51:28 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 17:48:08 UTC) #8
whywhat
Thanks for the review. PTAL!
5 years, 4 months ago (2015-07-30 21:24:50 UTC) #9
aurimas (slooooooooow)
lgtm
5 years, 4 months ago (2015-07-30 21:34:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266023002/20001
5 years, 4 months ago (2015-07-30 21:37:33 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 22:46:16 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:47:01 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0b69a3fb58aea4a762c326f4b4ba227eead44b28
Cr-Commit-Position: refs/heads/master@{#341214}

Powered by Google App Engine
This is Rietveld 408576698